fix: resolve cookie and localStorage failures in incognito mode - #35
Open
JesseKoldewijn wants to merge 6 commits into
Open
fix: resolve cookie and localStorage failures in incognito mode#35JesseKoldewijn wants to merge 6 commits into
JesseKoldewijn wants to merge 6 commits into
Conversation
Contributor
## [1.5.1-canary.1](v1.5.0...v1.5.1-canary.1) (2026-03-03) ### Bug Fixes * resolve cookie and localStorage failures in incognito mode ([bdd9cae](bdd9cae))
|
🎉 This PR is included in version 1.5.1-canary.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
5 tasks
- Replace bare injected localStorage scripts with try/catch wrappers that return structured results; add in-memory fallback (per-tab Map) when QuotaExceededError/SecurityError signals storage is unavailable - Expose handleApplyLS/handleRemoveLS/handleGetLS as named exports for direct unit-testing without message-routing overhead - Clean up per-tab memory in the existing tabs.onRemoved listener - Add storage_unavailable reason code and surface it via logIncognitoLocalStorageError in parameterApplicator - Warn when getTabCookieStoreId cannot locate the incognito cookie store instead of silently falling back to the wrong store - Replace typeof localStorage === "undefined" guards in featureFlags.ts with try/catch so private-window throws are caught rather than propagating uncaught - Add test/unit/entrypoints/background.test.ts proving memory fallback behaviour; extend featureFlags and parameterApplicator tests with private-window scenarios Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
sonarjs/no-undefined-argument — call isStorageUnavailableError() with no argument instead of explicitly passing undefined. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ator test Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
## [1.5.1-canary.2](v1.5.1-canary.1...v1.5.1-canary.2) (2026-08-27) ### Bug Fixes * **lint:** remove redundant undefined argument in background test ([2961817](2961817)) * properly handle private-window localStorage and cookie failures ([f360b75](f360b75))
|
🎉 This PR is included in version 1.5.1-canary.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix: #34