fix(security): M5c hidraw hardening — enumeration, FFI bounds, credential parsing#142
Merged
Jesssullivan merged 1 commit intomainfrom Apr 3, 2026
Merged
Conversation
Points to Jesssullivan/zig-ctap2#25: - Scan /sys/class/hidraw/ instead of hardcoded 0-15 range - FFI buffer bounds checks before all memcpy to caller buffers - Credential ID size bound (1024 bytes max) - HID descriptor parser bounds hardening - New CTAP2_ERR_NOT_ACCESSIBLE error for permission issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates zig-ctap2 submodule with security hardening (Jesssullivan/zig-ctap2#25):
/sys/class/hidraw/instead of hardcoded 0-15 range; fallback to 0-255 if sysfs unavailable@memcpyto caller-provided output buffersDevicesNotAccessible/CTAP2_ERR_NOT_ACCESSIBLEdistinguishes "no FIDO devices" from "found but can't open" (permissions/udev)Test plan