Skip to content

Add daily theme welcome nudge#118

Merged
Jesssullivan merged 5 commits into
mainfrom
shadow-deploy/theme-nudge
May 11, 2026
Merged

Add daily theme welcome nudge#118
Jesssullivan merged 5 commits into
mainfrom
shadow-deploy/theme-nudge

Conversation

@Jesssullivan
Copy link
Copy Markdown
Owner

Summary

  • Add a desktop-only daily Skeleton Popover nudge to the existing theme switcher.
  • Persist the nudge cadence with localStorage and keep manual theme interactions suppressing it for the day.
  • Add Playwright regression coverage for daily cadence, desktop-only behavior, Skeleton/Zag popover anatomy, and dark-mode style cascade inheritance.

Verification

  • Verified against Skeleton v4.15.2 / v5-next package metadata: stable is 4.15.2, next is 5.0.0-next.8, both depend on Zag popover/tooltip.
  • Confirmed Skeleton Popover is the right primitive for interactive links; direct Floating UI is only an advanced/custom attachment path and does not provide Popover accessibility out of the box.
  • npm run check
  • npm run lint
  • npx prettier --check src/lib/components/ThemeSwitcher.svelte e2e/dark-mode.spec.ts
  • git diff --cached --check

Shadow CI

@Jesssullivan Jesssullivan marked this pull request as ready for review May 11, 2026 05:14
@Jesssullivan Jesssullivan merged commit 8840d96 into main May 11, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant