Skip to content

fix: keep footer clear in previews#140

Draft
Jesssullivan wants to merge 1 commit into
mainfrom
codex/footer-preview-clearance
Draft

fix: keep footer clear in previews#140
Jesssullivan wants to merge 1 commit into
mainfrom
codex/footer-preview-clearance

Conversation

@Jesssullivan
Copy link
Copy Markdown
Owner

Summary

  • Increase the page footer's bottom padding so preview/browser bottom chrome no longer covers the final footer line.
  • Add a Playwright regression on the CV page at a preview-sized mobile viewport, checking the last visible footer content keeps at least 88px of clearance.

Root cause

The footer content previously had only about 48px of clearance at max scroll. That was visible in a raw browser viewport, but still vulnerable to preview surfaces with their own bottom chrome or overlays.

Validation

  • npm run build
  • npx playwright test e2e/navigation.spec.ts --project=chromium against npx serve build -l 3000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant