fix(payments): normalize public card method#63
Draft
Jesssullivan wants to merge 1 commit intomainfrom
Draft
Conversation
Owner
Author
|
Triage refresh 2026-04-25:
Recommended next action: rebase/rewrite this as a small payment-contract PR after the current package boundary/docs branch lands, then run the affected payment selector/hybrid checkout tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
cardat the package boundarystripealias readable internally during transitioncardandvenmoselections to error instead of falling through to manual completioncardidWhy
MassageIthacasurfaced a real divergence: Acuity capabilities exposed card ascard, whilescheduling-kitstill branched onstripein the hybrid drawer and registry. That let card flows miss Stripe checkout and fall through into incorrect local completion paths.Impact
This makes
scheduling-kitthe owner of the canonical public card payment id. Consumers can keep usingcardacross page and drawer shells while the package preserves internal Stripe processing semantics.Validation
/Users/jess/git/scheduling-kit/node_modules/.bin/vitest run src/tests/unit/core/pipelines.test.ts src/tests/unit/core/wizard-pipeline.test.ts src/tests/components/hybrid-checkout-state.test.ts tests/e2e/payment-selector.test.ts src/tests/hybrid-checkout-capabilities.test.tssvelte-checkremains noisy in this repo due pre-existing unrelated errors, so validation for this slice stayed focused to the affected payment controller and selector testsRoot cause
Public payment-method ids and internal adapter names were leaking across the same boundary. The registry, older checkout path, and hybrid drawer were not all consuming the same contract.