Skip to content

Make Data.Array.++.++_index-left signature consistent with ++_index-right#78

Open
JeJutic wants to merge 1 commit intoJetBrains:masterfrom
JeJutic:index-left-consistent
Open

Make Data.Array.++.++_index-left signature consistent with ++_index-right#78
JeJutic wants to merge 1 commit intoJetBrains:masterfrom
JeJutic:index-left-consistent

Conversation

@JeJutic
Copy link

@JeJutic JeJutic commented Jan 10, 2026

++_index-right has last parameter implicit while ++_index-left has it explicit:

\func ++_index-left {A : \Type} {l m : Array A} (i : Fin l.len) : (l ++ m) (index-left i) = l i
\func ++_index-right {A : \Type} {l m : Array A} {i : Fin m.len} : (l ++ m) (index-right i) = m i

It becomes slightly annoying when working with both versions at the same time. I thought the implicit variant is more suitable as ++_index-right is used more often in standard library.

First time contributing here, excuse me if I may not know some nuances

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant