Added separate executor#252
Merged
Merged
Conversation
Konstantin Barzilovich (kosstbarz)
marked this pull request as ready for review
Copilot started reviewing on behalf of
Yaroslav Sokolov (SokolovYaroslav)
March 11, 2026 15:26
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new “separate” execution mode that runs SQL directly against each datasource’s native SQLAlchemy engine (instead of routing through DuckDB), including Snowflake engine creation and schema introspection to populate the system prompt.
Changes:
- Introduce
SeparateExecutor+SeparateGraphwithrun_sql_query/submit_resulttools and a dedicated system prompt template. - Add SQLAlchemy-based Snowflake schema inspection (
information_schema.tables/columns) to generateTableInfo/ColumnInfofor prompt schema. - Extend database adapter plumbing with
try_create_sqlalchemy_engine()and a Snowflakecreate_sqlalchemy_engine()implementation.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| databao/agent/sqlalchemy/schema_inspection.py | New SQLAlchemy schema inspector (currently Snowflake-only) producing TableInfo/ColumnInfo. |
| databao/agent/sqlalchemy/init.py | Initializes databao.agent.sqlalchemy package. |
| databao/agent/executors/separate/system_prompt.jinja | New system prompt template for the separate executor (includes Snowflake quoting guidance). |
| databao/agent/executors/separate/separate_executor.py | New executor that builds per-datasource SQLAlchemy engines and injects schema into the prompt. |
| databao/agent/executors/separate/graph.py | New LangGraph tool loop to run SQL via SQLAlchemy engines and submit results. |
| databao/agent/databases/snowflake_adapter.py | Adds Snowflake SQLAlchemy engine creation from connection config (password/keypair/SSO). |
| databao/agent/databases/databases.py | Adds try_create_sqlalchemy_engine() helper to delegate engine creation to adapters. |
| databao/agent/databases/database_adapter.py | Adds optional create_sqlalchemy_engine() hook on adapters (default None). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Konstantin Barzilovich (@kosstbarz) please address the copilot's comments somehow :) I personally don't look into the code until AI is happy |
… additional properties
Lenar (catstrike)
force-pushed
the
kosst/separate-executor
branch
from
ca1d38d to
863a5c9
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 13 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…comma in Snowflake OAuth example.
Yaroslav Sokolov (SokolovYaroslav)
had a problem deploying
to
pypi
GitHub Actions
Failure
Yaroslav Sokolov (SokolovYaroslav)
had a problem deploying
to
pypi
GitHub Actions
Failure
Yaroslav Sokolov (SokolovYaroslav)
temporarily deployed
to
pypi
GitHub Actions
Inactive
Yaroslav Sokolov (SokolovYaroslav)
temporarily deployed
to
pypi
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 13 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ly SQL, add tests - Add TOKEN_KEY to AUTH_KEYS to prevent OAuth token from leaking into additional_properties via create_config_from_runtime - Add _validate_read_only() to reject DDL/DML in run_sql_query - Add tests/test_separate_executor.py covering executor init, schema inspection, and SQL validation - Add test for TOKEN_KEY exclusion in test_snowflake_adapter.py Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Simon Karan (SimonKaran13)
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.