BAZEL-3149: upgrade to toplevel only if remote_download_outputs=minimal#389
Open
christianladam wants to merge 1 commit intoJetBrains:261from
Open
Conversation
For Bazel builds that require all, the toplevel setting can break things. By only overriding remote_download_outputs when it was minimal we avoid causing problems in those specific cases. The execute service specifically only pulls the test xml, log, and lcov outputs, so a simple remote_download_regex works in that case and is less changes.
christianladam
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bazel builds that require all, the toplevel setting can break things. By only overriding remote_download_outputs when it was minimal we avoid causing problems in those specific cases.
The execute service specifically only pulls the test xml, log, and lcov outputs, so a simple remote_download_regex works in that case and is less changes.