Skip to content

BAZEL-3151: add sibling data to avoid class name collisions due to BAZEL-3117#390

Open
christianladam wants to merge 1 commit intoJetBrains:261from
christianladam:christianadam/jdeps_sibling_fix
Open

BAZEL-3151: add sibling data to avoid class name collisions due to BAZEL-3117#390
christianladam wants to merge 1 commit intoJetBrains:261from
christianladam:christianadam/jdeps_sibling_fix

Conversation

@christianladam
Copy link
Copy Markdown

If a build file isn't fine-grained per package then the current jdeps logic can result in a collision if two or more packages under a BUILD file have a class with the same name.

foo/src/main/java/BUILD (globs **/*.java, lists files individually, etc)
foo/src/main/java/com/foo/AClass.java
foo/src/main/java/com/foo/bar/AClass.java

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@jastice jastice requested review from aehlig and noxvost May 6, 2026 07:05
Copy link
Copy Markdown
Member

@aehlig aehlig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change as is looks good to me; so if you mark it as ready, I will try to import it.

@christianladam christianladam marked this pull request as ready for review May 6, 2026 14:17
@christianladam christianladam changed the title fix: add sibling data to avoid class name collisions due to BAZEL-3117 BAZEL-3151: add sibling data to avoid class name collisions due to BAZEL-3117 May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants