Skip to content

test: add ResumePreviewForm mouse interactivity tests#3431

Closed
Sakina-786-vi wants to merge 9 commits into
JhaSourav07:mainfrom
Sakina-786-vi:test/resume-preview-form-mouse-interactivity
Closed

test: add ResumePreviewForm mouse interactivity tests#3431
Sakina-786-vi wants to merge 9 commits into
JhaSourav07:mainfrom
Sakina-786-vi:test/resume-preview-form-mouse-interactivity

Conversation

@Sakina-786-vi

@Sakina-786-vi Sakina-786-vi commented Jun 3, 2026

Copy link
Copy Markdown

Description

Fixes #2697

Added a new test suite for ResumePreviewForm mouse interactivity behavior.
While working on this, I encountered challenges related to the existing project setup and integration requirements, which prevented me from fully completing the requested functionality.

Covered Scenarios

  • Tooltip visibility on mouse hover.
  • Tooltip rendering and coordinate positioning.
  • Click and touch event propagation.
  • Cursor pointer styling on interactive elements.
  • Hiding tooltip/overlay elements on mouse leave.

This PR only adds test coverage and does not introduce any UI or production code changes.

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

N/A — Test-only changes.

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally.
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format.
  • I have updated README.md if I added a new theme or URL parameter. (Not applicable)
  • I have started the repo. (This means a lot to us ❤️)
  • I have made sure that I have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (Not affected by this PR)
  • [] (Recommended) I joined the CommitPulse Discord server for faster collaboration, mentorship, and PR support.

@vercel

vercel Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

@Sakina-786-vi is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

👋 Hey @Sakina-786-vi, welcome to CommitPulse! 🎉

Thanks for opening your first pull request — this is a big deal and we appreciate the effort!

While you wait for a review, please double-check:

  • ✅ You've read the CONTRIBUTING.md checklist
  • npm run lint, npm run format, and npm run test all pass locally
  • ✅ Your PR has a visual preview if it touches any SVG output
  • 💬 You've joined our Discord for faster PR feedback

A maintainer will review your PR shortly. Hang tight! 🚀

@github-actions github-actions Bot added the status:blocked This PR is blocked due to a failing CI check. label Jun 3, 2026
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

🚨 Hey @Sakina-786-vi, the CI Pipeline is failing on this PR and it has been marked as status:blocked.

Please fix the issues before this can be reviewed. Here's how:

1. Run checks locally before pushing:

npm run format:check   # Check Prettier formatting
npm run lint           # Run ESLint
npm run typecheck      # TypeScript type check
npm run test           # Run unit tests (Vitest)
npm run build          # Verify production build passes

2. Auto-fix common issues:

npm run format         # Auto-fix formatting with Prettier
npm run lint -- --fix  # Auto-fix lint errors where possible

3. Check the full failure log here:
👉 View CI Run

Once you push a fix and the CI passes, the status:blocked label will be removed automatically. 💪

@Sakina-786-vi

Copy link
Copy Markdown
Author

Hii @JhaSourav07 as i have old version of laptop so i tried with old version of eslint but its throughing some environment error. But there is no error related to code and file i have added if you want you can check it out.

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for adding these tests! I ran them locally and it seems there's a minor issue with one of the queries in ResumePreviewForm.mouse-interactivity.test.tsx:

? components/dashboard/ResumePreviewForm.mouse-interactivity.test.tsx:82:38 80| fireEvent.click(addButtons[2]); 81| 82| const removeSkillButton = screen.getByRole('button', { name: /Remove skill React/i });

The test is throwing a TestingLibraryElementError here because it couldn't find the
emoveSkillButton. Could you please take a look and adjust the text matcher or query to make sure the element is correctly found?

Once that's fixed and the tests pass, this will be good to go!

@Aamod-Dev Aamod-Dev added GSSoC 2026 mentor:Aamod007 type:testing Adding, updating, or fixing tests level:intermediate Moderate complexity tasks labels Jun 3, 2026
@Sakina-786-vi Sakina-786-vi requested a review from Aamod-Dev June 4, 2026 05:32
@Sakina-786-vi

Copy link
Copy Markdown
Author

@Aamod007 can you review this now?

@Sakina-786-vi

Copy link
Copy Markdown
Author

Hii @JhaSourav07 plz review the pr

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The regex matcher fix looks perfect and the mouse-interactivity tests are passing now. Approved!

@Sakina-786-vi

Copy link
Copy Markdown
Author

Hi @Aamod007 can you merge this pr as more time it takes my rank will get lower

@Sakina-786-vi

Copy link
Copy Markdown
Author

Hi @Aamod007 can you merge this pr as more time it takes my rank will get lower

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate you taking the time to submit this PR. I went through the implementation and the approach looks solid.

Looks solid. I'll go ahead and approve.

@Aamod-Dev Aamod-Dev added level:beginner Small changes Usually isolated fixes or simple UI/text updates. quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. and removed level:intermediate Moderate complexity tasks labels Jun 13, 2026

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is currently marked with the \status:blocked\ label. Please resolve the blockers so we can proceed with a full review and approval.

@Aamod-Dev Aamod-Dev removed the level:beginner Small changes Usually isolated fixes or simple UI/text updates. label Jun 13, 2026
@Aamod-Dev Aamod-Dev added level:advanced Complex contributions involving architecture, optimization, or significant feature work quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:feature New features, additions, or enhancements and removed quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. labels Jun 13, 2026

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I went through the changes and have evaluated them according to the rubric.

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the issues that caused the blocked label before this can be approved.

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still blocked, so I’m keeping request changes. The mouse-interaction coverage in components/dashboard/ResumePreviewForm.mouse-interactivity.test.tsx is useful, but please clear the blocking CI state and then verify the event propagation and tooltip assertions against the current component API.

@JhaSourav07

Copy link
Copy Markdown
Owner

Closing the PR as CI is not passing and author is not fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GSSoC 2026 level:advanced Complex contributions involving architecture, optimization, or significant feature work mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. status:blocked This PR is blocked due to a failing CI check. type:feature New features, additions, or enhancements type:testing Adding, updating, or fixing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(ResumePreviewForm-mouse-interactivity): verify Interactive Tooltips, Cursor Hovers & Touch Event Propagation (Variation 5)

3 participants