test: add ResumePreviewForm mouse interactivity tests#3431
test: add ResumePreviewForm mouse interactivity tests#3431Sakina-786-vi wants to merge 9 commits into
Conversation
|
@Sakina-786-vi is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
👋 Hey @Sakina-786-vi, welcome to CommitPulse! 🎉 Thanks for opening your first pull request — this is a big deal and we appreciate the effort! While you wait for a review, please double-check:
A maintainer will review your PR shortly. Hang tight! 🚀 |
|
🚨 Hey @Sakina-786-vi, the CI Pipeline is failing on this PR and it has been marked as Please fix the issues before this can be reviewed. Here's how: 1. Run checks locally before pushing: npm run format:check # Check Prettier formatting
npm run lint # Run ESLint
npm run typecheck # TypeScript type check
npm run test # Run unit tests (Vitest)
npm run build # Verify production build passes2. Auto-fix common issues: npm run format # Auto-fix formatting with Prettier
npm run lint -- --fix # Auto-fix lint errors where possible3. Check the full failure log here: Once you push a fix and the CI passes, the |
|
Hii @JhaSourav07 as i have old version of laptop so i tried with old version of eslint but its throughing some environment error. But there is no error related to code and file i have added if you want you can check it out. |
Aamod-Dev
left a comment
There was a problem hiding this comment.
Hi! Thanks for adding these tests! I ran them locally and it seems there's a minor issue with one of the queries in ResumePreviewForm.mouse-interactivity.test.tsx:
? components/dashboard/ResumePreviewForm.mouse-interactivity.test.tsx:82:38 80| fireEvent.click(addButtons[2]); 81| 82| const removeSkillButton = screen.getByRole('button', { name: /Remove skill React/i });
The test is throwing a TestingLibraryElementError here because it couldn't find the
emoveSkillButton. Could you please take a look and adjust the text matcher or query to make sure the element is correctly found?
Once that's fixed and the tests pass, this will be good to go!
|
@Aamod007 can you review this now? |
|
Hii @JhaSourav07 plz review the pr |
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thank you! The regex matcher fix looks perfect and the mouse-interactivity tests are passing now. Approved!
|
Hi @Aamod007 can you merge this pr as more time it takes my rank will get lower |
|
Hi @Aamod007 can you merge this pr as more time it takes my rank will get lower |
Aamod-Dev
left a comment
There was a problem hiding this comment.
Appreciate you taking the time to submit this PR. I went through the implementation and the approach looks solid.
Looks solid. I'll go ahead and approve.
Aamod-Dev
left a comment
There was a problem hiding this comment.
This PR is currently marked with the \status:blocked\ label. Please resolve the blockers so we can proceed with a full review and approval.
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I went through the changes and have evaluated them according to the rubric.
Aamod-Dev
left a comment
There was a problem hiding this comment.
Please fix the issues that caused the blocked label before this can be approved.
Aamod-Dev
left a comment
There was a problem hiding this comment.
This is still blocked, so I’m keeping request changes. The mouse-interaction coverage in components/dashboard/ResumePreviewForm.mouse-interactivity.test.tsx is useful, but please clear the blocking CI state and then verify the event propagation and tooltip assertions against the current component API.
|
Closing the PR as CI is not passing and author is not fixing it. |
Description
Fixes #2697
Added a new test suite for
ResumePreviewFormmouse interactivity behavior.While working on this, I encountered challenges related to the existing project setup and integration requirements, which prevented me from fully completing the requested functionality.
Covered Scenarios
This PR only adds test coverage and does not introduce any UI or production code changes.
Pillar
Visual Preview
N/A — Test-only changes.
Checklist before requesting a review:
CONTRIBUTING.mdfile.npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).README.mdif I added a new theme or URL parameter. (Not applicable)