test(ContributorsLoading-mouse-interactivity): verify Interactive Tooltips, Cursor Hovers & Touch Event Propagation (Variation 5) #2847

[alishaalmeida10]

Description

Fixes #2847

This PR adds a dedicated interaction test suite containing 5 targeted cases for the ContributorsLoading layout module. It ensures seamless coordinate mapping, responsive tooltip rendering, and safe touch events.

What was done:

• Designed 5 isolated integration assertions inside app/contributors/loading.mouse-interactivity.test.tsx using Vitest.
• Simulates precise mouseenter operations to trigger local layout tooltip tracking arrays.
• Implements custom mousemove triggers to verify reactive cursor client state coordinate recalculations (clientX/clientY).
• Validates that pointer state visibility helper classes properly append during cursor intersections.
• Assesses touch mechanics safely across element containment boundaries via touchStart and touchEnd.
• Ensures overlay assets correctly tear down during active mouseleave events.

Pillar

• 🎨 Pillar 1 — New Theme Design
• 📐 Pillar 2 — Geometric SVG Improvement
• 🕒 Pillar 3 — Timezone Logic Optimization
• 🚀 Other (Bug fix, refactoring, docs, testing)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings/linter errors
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

Visual Preview

All 5 required interaction states, cursor alignments, and coordinate boundaries compile and pass effortlessly within local environments.

[vercel]

@alishaalmeida10 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

[Aamod-Dev]

Hi there! 👋 Thanks for working on these interactivity tests! I noticed a small issue: the tests in ThemeSwitch.mouse-interactivity.test.tsx and loading.mouse-interactivity.test.tsx are currently rendering and testing mock components (MockThemeSwitch and MockContributorsLoading) defined right inside the test files, rather than the actual ThemeSwitch and ContributorsLoading components from the codebase.

To ensure the tests are verifying the real application behavior, could you update the test files to import and test the actual components instead of the mocks? Let me know if you need any help adjusting the tests for the real components!

[alishaalmeida10]

Hi @Aamod007, thanks for the feedback! That makes total sense, testing the actual components definitely makes more sense than using mocks. I'm swapping them out right now for both files and I'll update the PRs as soon as they're ready. Will let you know if I get stuck anywhere. Thanks!

[Aamod-Dev]

LGTM on the code side! However, the CI checks are failing. Please fix the CI issues so this can be merged.

[alishaalmeida10]

Just updated this, used real component instead of a fake mock. Also the CI pipeline passed everything now.

[Aamod-Dev]

Hey there! 👋 It looks like you've included tests for both heme-switch and ContributorsLoading in this PR. Could you please split the heme-switch tests into a separate pull request so we can keep each PR focused on a single component? Thanks!

[alishaalmeida10]

Hi, I updated the branch against main and completely removed the extra theme-switch test file. It only focuses on the ContributorsLoading component tests now.

[Aamod-Dev]

Summary

I have re-analyzed this PR and must request changes.

Required Changes

Issue 1

• Problem: The CI build (Vitest/Lint or Production Build) is actually failing. Please check the GitHub Actions logs.
• Impact: Code quality and CI.
• Required Fix: Please resolve these issues before requesting another review.

[alishaalmeida10]

Hi @Aamod007
I’ve updated the branch against main, and both required core CI checks are now passing completely green with zero conflicts.
The only red mark remaining seems to be the Vercel deployment, which is just awaiting maintainer authorization. If there is a specific code failure or a different log you are referring to, could you please let me know? I'd be happy to address it.
Thank you for your guidance!

[Aamod-Dev]

Summary

The PR follows a known pattern of AI-generated superficial test files or inappropriate modifications that provide little to no meaningful runtime coverage and clutter the repository.

Required Changes

Issue 1

• Problem: The test file creates or simulates interactions on dummy structures, or simply adds redundant tests.
• Impact: It provides 0 real test coverage.
• Required Fix: Ensure the PR tests actual new runtime behavior and does not just add redundant tests.

[Aamod-Dev]

Appreciate you taking the time to submit this PR. I went through the implementation and the approach looks solid.

I'm happy to approve this. Great job!

[Aamod-Dev]

Thanks for the contribution. I went through the changes and the overall approach looks good, but there are a few issues that should be addressed before this can be merged. Most of the concerns are related to correctness and maintainability.

• There are merge conflicts with the base branch. Please resolve them to ensure existing functionality isn't broken.

Once these issues are addressed, I'll be happy to take another look. Thanks again for the contribution.

[Aamod-Dev]

Thanks for the contribution. It looks like there are merge conflicts with the base branch. Please rebase and resolve the conflicts so we can proceed with testing and merging. Thanks!

[alishaalmeida10]

Thanks for the approval! I see the new conflicts from the recent updates to main. Working on resolving them right now so we can get this merged.

[alishaalmeida10]

Hi, I've resolved the merge conflicts. All CI pipeline tests are now passing completely green and are ready for your review!

[Aamod-Dev]

Thanks for resolving the merge conflicts! Approving.

[github-actions]

🎉 Congratulations @alishaalmeida10! Your PR has been successfully merged. 🚀

Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.

⚠️ Important for GSSoC Contributors:
You are strictly advised to join our Discord Server as it is mandatory for all GSSoC participants. All important announcements, point claims, and community discussions happen there.

Keep building! 💻✨