Skip to content

Add ActivityLandscape tests; adjust CommitClock#3865

Merged
JhaSourav07 merged 2 commits into
JhaSourav07:mainfrom
devxnshsharma:main
Jun 12, 2026
Merged

Add ActivityLandscape tests; adjust CommitClock#3865
JhaSourav07 merged 2 commits into
JhaSourav07:mainfrom
devxnshsharma:main

Conversation

@devxnshsharma

Copy link
Copy Markdown
Contributor

Add a new responsive-breakpoints test file for ActivityLandscape to validate mobile layout, overflow, tab wrapping, graph scaling and flexible bar sizing. Tweak CommitClock massive-scaling tests to improve CI stability by reducing the huge dataset (7000 -> 1000), adding per-test timeouts (15s) for heavy renders, removing some redundant extreme-value entries, and relaxing the render-time assertion to allow up to 8s. These changes aim to reduce JSDOM memory/timeout issues and flakiness while still covering large-input behavior.

Description

Fixes #2489
npm run test components/dashboard/ActivityLandscape.responsive-breakpoints.test.tsx

commitpulse@0.1.0 test
vitest run components/dashboard/ActivityLandscape.responsive-breakpoints.test.tsx
RUN v4.1.8
✓ components/dashboard/ActivityLandscape.responsive-breakpoints.test.tsx (5 tests) 40ms
✓ ActivityLandscape Component - Responsive Layouts (5)
✓ reflows the header layout from row to column on mobile viewports 28ms
✓ ensures no horizontal overflow on mobile viewports 2ms
✓ renders tab navigation in a flexible container for mobile 2ms
✓ maintains absolute scale consistency on mobile to prevent visual clipping 3ms
✓ verifies that the mobile viewport does not force absolute widths 3ms
Test Files 1 passed (1)
Tests 5 passed (5)
Start at 23:18:56
Duration 868ms (transform 25ms, setup 58ms, import 144ms, tests 40ms, environment 471ms)

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
  • I have updated README.md if I added a new theme or URL parameter.
  • I have started the repo.
  • I have made sure that i have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
  • (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

👋 Hey @devxnshsharma, welcome to CommitPulse! 🎉

Thanks for opening your first pull request — this is a big deal and we appreciate the effort!

While you wait for a review, please double-check:

  • ✅ You've read the CONTRIBUTING.md checklist
  • npm run lint, npm run format, and npm run test all pass locally
  • ✅ Your PR has a visual preview if it touches any SVG output
  • 💬 You've joined our Discord for faster PR feedback

A maintainer will review your PR shortly. Hang tight! 🚀

@devxnshsharma

Copy link
Copy Markdown
Contributor Author

@JhaSourav07 kindly see and merge

@vercel

vercel Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

@devxnshsharma is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! 👋 Thanks for the PR. It looks like you've included multiple unrelated tests (ActivityLandscape and CommitClock) as well as modifications to package-lock.json. Could you please separate the tests into individual PRs and revert the package-lock.json changes to keep the PR focused? Thank you!

@Aamod-Dev Aamod-Dev added GSSoC 2026 mentor:Aamod007 level:beginner Small changes Usually isolated fixes or simple UI/text updates. level:advanced Complex contributions involving architecture, optimization, or significant feature work quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. and removed level:beginner Small changes Usually isolated fixes or simple UI/text updates. labels Jun 5, 2026

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. I've taken a look at the changes and everything seems to align with what we need here.

I am adding the quality:exceptional label because the implementation not only solves the core issue but goes beyond by effectively handling edge cases, tests, or reducing technical debt. Great work going above and beyond!

Merging this looks safe. Approved!

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. I went through the changes and the overall approach looks good, but there are a few issues that should be addressed before this can be merged. Most of the concerns are related to correctness and maintainability.

  • There are merge conflicts with the base branch. Please resolve them to ensure existing functionality isn't broken.

Once these issues are addressed, I'll be happy to take another look. Thanks again for the contribution.

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. It looks like there are merge conflicts with the base branch. Please rebase and resolve the conflicts so we can proceed with testing and merging. Thanks!

Add a new responsive-breakpoints test file for ActivityLandscape to validate mobile layout, overflow, tab wrapping, graph scaling and flexible bar sizing. Tweak CommitClock massive-scaling tests to improve CI stability by reducing the huge dataset (7000 -> 1000), adding per-test timeouts (15s) for heavy renders, removing some redundant extreme-value entries, and relaxing the render-time assertion to allow up to 8s. These changes aim to reduce JSDOM memory/timeout issues and flakiness while still covering large-input behavior.
@devxnshsharma

Copy link
Copy Markdown
Contributor Author

@Aamod007
I've rebased the branch to resolve the merge conflicts and reverted the package-lock.json file as requested.
All checks are passing, let me know if it's good to merge

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for resolving the merge conflicts! Approving.

@JhaSourav07 JhaSourav07 added the gssoc:approved PR has been reviewed and accepted for valid contribution points label Jun 12, 2026
@JhaSourav07 JhaSourav07 merged commit d232f0c into JhaSourav07:main Jun 12, 2026
5 of 6 checks passed
@github-actions github-actions Bot added this to the GSSoC 2026 milestone Jun 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🎉 Congratulations @devxnshsharma! Your PR has been successfully merged. 🚀

Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.

⚠️ Important for GSSoC Contributors:
You are strictly advised to join our Discord Server as it is mandatory for all GSSoC participants. All important announcements, point claims, and community discussions happen there.

Keep building! 💻✨

@JhaSourav07 JhaSourav07 added gssoc:approved PR has been reviewed and accepted for valid contribution points and removed gssoc:approved PR has been reviewed and accepted for valid contribution points labels Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved PR has been reviewed and accepted for valid contribution points gssoc:needs-rebase GSSoC 2026 level:advanced Complex contributions involving architecture, optimization, or significant feature work mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(ActivityLandscape-responsive-breakpoints): verify Responsive Multi-device Columns & Mobile Viewport Layouts (Variation 7)

3 participants