Add ActivityLandscape tests; adjust CommitClock#3865
Conversation
|
👋 Hey @devxnshsharma, welcome to CommitPulse! 🎉 Thanks for opening your first pull request — this is a big deal and we appreciate the effort! While you wait for a review, please double-check:
A maintainer will review your PR shortly. Hang tight! 🚀 |
|
@JhaSourav07 kindly see and merge |
|
@devxnshsharma is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
Aamod-Dev
left a comment
There was a problem hiding this comment.
Hi there! 👋 Thanks for the PR. It looks like you've included multiple unrelated tests (ActivityLandscape and CommitClock) as well as modifications to package-lock.json. Could you please separate the tests into individual PRs and revert the package-lock.json changes to keep the PR focused? Thank you!
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I've taken a look at the changes and everything seems to align with what we need here.
I am adding the quality:exceptional label because the implementation not only solves the core issue but goes beyond by effectively handling edge cases, tests, or reducing technical debt. Great work going above and beyond!
Merging this looks safe. Approved!
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I went through the changes and the overall approach looks good, but there are a few issues that should be addressed before this can be merged. Most of the concerns are related to correctness and maintainability.
- There are merge conflicts with the base branch. Please resolve them to ensure existing functionality isn't broken.
Once these issues are addressed, I'll be happy to take another look. Thanks again for the contribution.
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for the contribution. It looks like there are merge conflicts with the base branch. Please rebase and resolve the conflicts so we can proceed with testing and merging. Thanks!
Add a new responsive-breakpoints test file for ActivityLandscape to validate mobile layout, overflow, tab wrapping, graph scaling and flexible bar sizing. Tweak CommitClock massive-scaling tests to improve CI stability by reducing the huge dataset (7000 -> 1000), adding per-test timeouts (15s) for heavy renders, removing some redundant extreme-value entries, and relaxing the render-time assertion to allow up to 8s. These changes aim to reduce JSDOM memory/timeout issues and flakiness while still covering large-input behavior.
|
@Aamod007 |
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for resolving the merge conflicts! Approving.
|
🎉 Congratulations @devxnshsharma! Your PR has been successfully merged. 🚀 Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.
Keep building! 💻✨ |
Add a new responsive-breakpoints test file for ActivityLandscape to validate mobile layout, overflow, tab wrapping, graph scaling and flexible bar sizing. Tweak CommitClock massive-scaling tests to improve CI stability by reducing the huge dataset (7000 -> 1000), adding per-test timeouts (15s) for heavy renders, removing some redundant extreme-value entries, and relaxing the render-time assertion to allow up to 8s. These changes aim to reduce JSDOM memory/timeout issues and flakiness while still covering large-input behavior.
Description
Fixes #2489
npm run test components/dashboard/ActivityLandscape.responsive-breakpoints.test.tsx
Pillar
Visual Preview
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.