fix: Patch moderate severity XSS vulnerability in postcss (<8.5.10)#4858
Conversation
|
@Kokila-chandrakar is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
🚨 Hey @Kokila-chandrakar, the CI Pipeline is failing on this PR and it has been marked as Please fix the issues before this can be reviewed. Here's how: 1. Run checks locally before pushing: npm run format:check # Check Prettier formatting
npm run lint # Run ESLint
npm run typecheck # TypeScript type check
npm run test # Run unit tests (Vitest)
npm run build # Verify production build passes2. Auto-fix common issues: npm run format # Auto-fix formatting with Prettier
npm run lint -- --fix # Auto-fix lint errors where possible3. Check the full failure log here: Once you push a fix and the CI passes, the |
Aamod-Dev
left a comment
There was a problem hiding this comment.
Great catch! Patching the PostCSS XSS vulnerability is critical for maintaining project security. Approving!
Aamod-Dev
left a comment
There was a problem hiding this comment.
Good work on this one. I reviewed the diff and it looks ready to go from my side.
Merging this looks safe. Approved!
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I went through the changes and the overall approach looks good, but there are a few issues that should be addressed before this can be merged. Most of the concerns are related to correctness and maintainability.
- There are merge conflicts with the base branch. Please resolve them to ensure existing functionality isn't broken.
Once these issues are addressed, I'll be happy to take another look. Thanks again for the contribution.
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for the contribution. It looks like there are merge conflicts with the base branch. Please rebase and resolve the conflicts so we can proceed with testing and merging. Thanks!
|
Rebased and resolved all conflicts with upstream main. Ready for re-review. Thanks! |
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for resolving the merge conflicts! Approving.
|
🎉 Congratulations @Kokila-chandrakar! Your PR has been successfully merged. 🚀 Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.
Keep building! 💻✨ |
Description
Fixes #4840
Resolves a moderate severity Cross-Site Scripting (XSS) vulnerability in
postcssversions<8.5.10, where unescaped</style>tags in CSS stringify output could be exploited.Changes
postcssdevDependency from^8.5.9to^8.5.10overridesinpackage.jsonto enforcepostcss >= 8.5.10across the dependency treenext/node_modules/postcssfrom8.4.31to8.5.15inpackage-lock.jsonWhy overrides?
Next.js includes its own internal copy of PostCSS (
8.4.31), which was also affected. Theoverridesfield ensures a patched version is used throughout the entire dependency tree.Testing
npm auditreports no moderate/high PostCSS vulnerabilitiesnpm test)Pillar
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.