test: add theme contrast coverage for RefreshButton component#4979
Conversation
|
@kanishka-2007-tech is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
Aamod-Dev
left a comment
There was a problem hiding this comment.
Great coverage! Ensuring the RefreshButton correctly respects light and dark mode variables means it will always look integrated into the chosen theme. Approving!
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I went through the changes and the overall approach looks good. The theme contrast test cases ensure our UI remains cohesive in both light and dark modes. Looks good to merge.
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for the PR. I've reviewed the changes and they look good to me.
I'm happy to approve this. Great job!
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I went through the changes and the overall approach looks good, but there are a few issues that should be addressed before this can be merged. Most of the concerns are related to correctness and maintainability.
- There are merge conflicts with the base branch. Please resolve them to ensure existing functionality isn't broken.
Once these issues are addressed, I'll be happy to take another look. Thanks again for the contribution.
|
@Aamod007 sir i am working on it . thankyou |
045d56e to
1fe1d17
Compare
|
🚨 Hey @kanishka-2007-tech, the CI Pipeline is failing on this PR and it has been marked as Please fix the issues before this can be reviewed. Here's how: 1. Run checks locally before pushing: npm run format:check # Check Prettier formatting
npm run lint # Run ESLint
npm run typecheck # TypeScript type check
npm run test # Run unit tests (Vitest)
npm run build # Verify production build passes2. Auto-fix common issues: npm run format # Auto-fix formatting with Prettier
npm run lint -- --fix # Auto-fix lint errors where possible3. Check the full failure log here: Once you push a fix and the CI passes, the |
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I went through the changes and the overall approach looks good. The theme contrast test cases are written cleanly and cover the component's styling well. However, I noticed that the CI pipeline is currently failing for this PR.
- The \Format · Lint · Typecheck · Test\ CI job has failed. Please run
pm run format,
pm run lint, and
pm run test\ locally to identify and resolve the issue.
Once these issues are addressed and the CI is green, I'll be happy to take another look and get this merged. Thanks again for the contribution.
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for the contribution. The overall approach looks good, but the CI pipeline is currently failing. Please run the checks (like npm run format, npm run lint, and npm run test) locally to identify and fix the issues. Let me know once it's green!
|
@Aamod007 @JhaSourav07 app/api/student/resume/confirm/route.theme-contrast.test.ts is an unecessary file as it is a theme contrast test but it is testing api logic can you please remove it or resolve the error as it is causing ci pipeline failure |
cd9d9b2 to
3800704
Compare
|
Deployment failed with the following error: |
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for fixing the CI pipeline! Approving.
|
🎉 Congratulations @kanishka-2007-tech! Your PR has been successfully merged. 🚀 Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.
Keep building! 💻✨ |
Description
Adds comprehensive theme contrast tests for the
RefreshButtoncomponent to ensure visual cohesion and accessibility across both light and dark modes.Changes Made
Added new test file:
components/dashboard/RefreshButton.theme-contrast.test.tsxAdded coverage for:
Fixes #2595
Pillar
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.