test: add readmeGenerator accessibility coverage#4981
Conversation
|
@mayank200529 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for the PR. I am requesting changes because this adds an 'accessibility' test suite to the 'readmeGenerator' utility. The readme generator creates markdown strings on the server and does not render HTML DOM elements with ARIA roles or focus states. Testing it for accessibility is invalid. Please remove this test or target an interactive UI component.
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I went through the changes and the overall approach looks good. The accessibility improvements and ARIA attribute coverage look great and will really help screen reader users. Happy to approve this.
|
who will merge this pr?? |
b4aec40 to
527b2b1
Compare
|
issue solved merge pr |
|
🚨 Hey @mayank200529, the CI Pipeline is failing on this PR and it has been marked as Please fix the issues before this can be reviewed. Here's how: 1. Run checks locally before pushing: npm run format:check # Check Prettier formatting
npm run lint # Run ESLint
npm run typecheck # TypeScript type check
npm run test # Run unit tests (Vitest)
npm run build # Verify production build passes2. Auto-fix common issues: npm run format # Auto-fix formatting with Prettier
npm run lint -- --fix # Auto-fix lint errors where possible3. Check the full failure log here: Once you push a fix and the CI passes, the |
Aamod-Dev
left a comment
There was a problem hiding this comment.
Good work on this one. I reviewed the diff and it looks ready to go from my side.
No concerns from my end. Approved.
Aamod-Dev
left a comment
There was a problem hiding this comment.
This PR is currently marked with the \status:blocked\ label. Please resolve the blockers so we can proceed with a full review and approval.
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I went through the changes and have evaluated them according to the rubric.
Aamod-Dev
left a comment
There was a problem hiding this comment.
Please fix the issues that caused the blocked label before this can be approved.
|
If you are still working on this, please push your latest changes or leave a comment to keep it active. |
Aamod-Dev
left a comment
There was a problem hiding this comment.
Difficulty: intermediate – Accessibility tests for screen reader aria compliance.
Quality: clean – A11y coverage.
Type: testing + accessibility – Important a11y work.
Great tests!
Aamod-Dev
left a comment
There was a problem hiding this comment.
Review
This PR cannot be approved in its current state due to blocking issues (status:blocked label, merge conflicts, needs-rebase label, and/or failing CI checks). Please resolve the blocking issues and re-request review.
Once unblocked, I'm happy to re-review! 💚
Aamod-Dev
left a comment
There was a problem hiding this comment.
Adding accessibility tests for readmeGenerator is fantastic. Ensuring that headings, alt text, and social icons generated in READMEs comply with accessibility standards is a great win. However, this PR is currently marked as blocked. Please resolve the blocking issues so we can merge this in.
Description
Fixes #4590
Added accessibility-focused test coverage for
readmeGenerator.Coverage
altandtitleattributes.Pillar
Visual Preview
N/A (test-only change)
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.