Skip to content

test(trustedProxy-massive-scaling): verify Massive Data Sets and Extr…#5054

Merged
JhaSourav07 merged 10 commits into
JhaSourav07:mainfrom
rashi-gupta-08:test/optimizer-modal-v10
Jun 12, 2026
Merged

test(trustedProxy-massive-scaling): verify Massive Data Sets and Extr…#5054
JhaSourav07 merged 10 commits into
JhaSourav07:mainfrom
rashi-gupta-08:test/optimizer-modal-v10

Conversation

@rashi-gupta-08

Copy link
Copy Markdown
Contributor

Description

Adds 5 new test cases verifying that trustedProxy utility handles massive
data sets and extreme high bounds scaling correctly. Tests cover 10000
trusted proxy IPs, 10000 sequential ip4ToInt conversions, 10000 CIDR
checks, 10000 IPv4 validations, and rejection of untrusted IPs under
high load — all within 500ms performance limits.

Fixes #4427

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

N/A — test file only, no visual output changes.

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally.
  • I have run npm run format and npm run lint locally and resolved all errors.
  • My commits follow the Conventional Commits format.
  • I have updated README.md if I added a new theme or URL parameter.
  • I have started the repo.
  • I have made sure that i have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard.
  • (Recommended) I joined the CommitPulse Discord community.

@vercel

vercel Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Someone is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Aamod-Dev Aamod-Dev added level:beginner Small changes Usually isolated fixes or simple UI/text updates. GSSoC 2026 mentor:Aamod007 labels Jun 11, 2026

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I must request changes because this adds 'massive-scaling' tests to the 'trustedProxy' utility. The trusted proxy utility simply manages a static list or basic matching logic for IP addresses. Subjecting it to 'massive data sets' testing does not provide meaningful coverage and reads like an AI-generated template applied to the wrong file. Please focus tests on the actual logic of the utility.

@github-actions github-actions Bot added the status:blocked This PR is blocked due to a failing CI check. label Jun 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚨 Hey @rashi-gupta-08, the CI Pipeline is failing on this PR and it has been marked as status:blocked.

Please fix the issues before this can be reviewed. Here's how:

1. Run checks locally before pushing:

npm run format:check   # Check Prettier formatting
npm run lint           # Run ESLint
npm run typecheck      # TypeScript type check
npm run test           # Run unit tests (Vitest)
npm run build          # Verify production build passes

2. Auto-fix common issues:

npm run format         # Auto-fix formatting with Prettier
npm run lint -- --fix  # Auto-fix lint errors where possible

3. Check the full failure log here:
👉 View CI Run

Once you push a fix and the CI passes, the status:blocked label will be removed automatically. 💪

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! This PR currently has a blocked status. Please resolve the blocking issues so we can proceed with a full review.

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for adding these tests. They run great and pass comfortably under the 500ms limit! However, there are two issues that need to be addressed before we can merge this:

  1. Unintended package-lock.json changes: It looks like package-lock.json was accidentally modified in this branch (over 700 deletions). Please revert the changes to this file to avoid breaking the build or causing dependency issues.
  2. Excluded Test File: The new test file utils/trustedProxy.massive-scaling.test.ts is explicitly excluded in our vitest.config.ts. This means it won't run in CI. If the intention is to keep these tests excluded from the standard run, please add a dedicated script in package.json to run them, or adjust the exclusion if it was unintentional.

Could you please address these? Thank you!

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. It looks like there are merge conflicts with the base branch. Please rebase and resolve the conflicts so we can proceed with testing and merging. Thanks!

@github-actions github-actions Bot removed the status:blocked This PR is blocked due to a failing CI check. label Jun 12, 2026

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for resolving the merge conflicts! Approving.

@JhaSourav07 JhaSourav07 added the gssoc:approved PR has been reviewed and accepted for valid contribution points label Jun 12, 2026
@JhaSourav07 JhaSourav07 merged commit 6dad518 into JhaSourav07:main Jun 12, 2026
5 checks passed
@github-actions github-actions Bot added this to the GSSoC 2026 milestone Jun 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🎉 Congratulations @rashi-gupta-08! Your PR has been successfully merged. 🚀

Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.

⚠️ Important for GSSoC Contributors:
You are strictly advised to join our Discord Server as it is mandatory for all GSSoC participants. All important announcements, point claims, and community discussions happen there.

Keep building! 💻✨

@Aamod-Dev Aamod-Dev added quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:test labels Jun 13, 2026
@JhaSourav07 JhaSourav07 removed the gssoc:approved PR has been reviewed and accepted for valid contribution points label Jun 17, 2026
@JhaSourav07 JhaSourav07 added the gssoc:approved PR has been reviewed and accepted for valid contribution points label Jun 17, 2026
@github-actions github-actions Bot added type:testing Adding, updating, or fixing tests and removed type:test labels Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved PR has been reviewed and accepted for valid contribution points GSSoC 2026 level:beginner Small changes Usually isolated fixes or simple UI/text updates. mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:testing Adding, updating, or fixing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(trustedProxy-massive-scaling): verify Massive Data Sets and Extreme High Bounds Scaling (Variation 2)

3 participants