test(trustedProxy-massive-scaling): verify Massive Data Sets and Extr…#5054
Conversation
…eme High Bounds Scaling
|
Someone is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for the PR. I must request changes because this adds 'massive-scaling' tests to the 'trustedProxy' utility. The trusted proxy utility simply manages a static list or basic matching logic for IP addresses. Subjecting it to 'massive data sets' testing does not provide meaningful coverage and reads like an AI-generated template applied to the wrong file. Please focus tests on the actual logic of the utility.
|
🚨 Hey @rashi-gupta-08, the CI Pipeline is failing on this PR and it has been marked as Please fix the issues before this can be reviewed. Here's how: 1. Run checks locally before pushing: npm run format:check # Check Prettier formatting
npm run lint # Run ESLint
npm run typecheck # TypeScript type check
npm run test # Run unit tests (Vitest)
npm run build # Verify production build passes2. Auto-fix common issues: npm run format # Auto-fix formatting with Prettier
npm run lint -- --fix # Auto-fix lint errors where possible3. Check the full failure log here: Once you push a fix and the CI passes, the |
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for the contribution! This PR currently has a blocked status. Please resolve the blocking issues so we can proceed with a full review.
Aamod-Dev
left a comment
There was a problem hiding this comment.
Hi! Thanks for adding these tests. They run great and pass comfortably under the 500ms limit! However, there are two issues that need to be addressed before we can merge this:
- Unintended
package-lock.jsonchanges: It looks likepackage-lock.jsonwas accidentally modified in this branch (over 700 deletions). Please revert the changes to this file to avoid breaking the build or causing dependency issues. - Excluded Test File: The new test file
utils/trustedProxy.massive-scaling.test.tsis explicitly excluded in ourvitest.config.ts. This means it won't run in CI. If the intention is to keep these tests excluded from the standard run, please add a dedicated script inpackage.jsonto run them, or adjust the exclusion if it was unintentional.
Could you please address these? Thank you!
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for the contribution. It looks like there are merge conflicts with the base branch. Please rebase and resolve the conflicts so we can proceed with testing and merging. Thanks!
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for resolving the merge conflicts! Approving.
|
🎉 Congratulations @rashi-gupta-08! Your PR has been successfully merged. 🚀 Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.
Keep building! 💻✨ |
Description
Adds 5 new test cases verifying that trustedProxy utility handles massive
data sets and extreme high bounds scaling correctly. Tests cover 10000
trusted proxy IPs, 10000 sequential ip4ToInt conversions, 10000 CIDR
checks, 10000 IPv4 validations, and rejection of untrusted IPs under
high load — all within 500ms performance limits.
Fixes #4427
Pillar
Visual Preview
N/A — test file only, no visual output changes.
Checklist before requesting a review:
CONTRIBUTING.mdfile.npm run formatandnpm run lintlocally and resolved all errors.README.mdif I added a new theme or URL parameter.