Skip to content

test(urls-accessibility): add accessibility and scaling coverage#5105

Closed
Subhooo5 wants to merge 2 commits into
JhaSourav07:mainfrom
Subhooo5:test/urls-accessibility-compliance
Closed

test(urls-accessibility): add accessibility and scaling coverage#5105
Subhooo5 wants to merge 2 commits into
JhaSourav07:mainfrom
Subhooo5:test/urls-accessibility-compliance

Conversation

@Subhooo5

@Subhooo5 Subhooo5 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes #4661

  • Added utils/urls.accessibility.test.ts with 5 accessibility-focused tests validating ARIA relationships, keyboard focus visibility, tooltip descriptions, tab ordering, and heading hierarchy around dashboard URL interactions.

Pillar

  • 🛠️ Other (Bug fix, refactoring, docs)

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors.
  • My commits follow the Conventional Commits format.
  • I have starred the repo.
  • I have made sure that i have only one commit to merge in this PR.

@Subhooo5

Subhooo5 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Hey @JhaSourav07 Test added successfully. All existing tests pass locally. Feel free to review, add necessary labels and merge it. 🫂🚀

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I have to request changes. You added an accessibility test suite for 'utils/urls.ts' testing ARIA relationships and focus visibility. A URL construction utility file does not render HTML or manage DOM focus, so it cannot have ARIA attributes. Please target accessibility tests only at valid UI components (.tsx).

@Subhooo5 Subhooo5 force-pushed the test/urls-accessibility-compliance branch from 8b7eab5 to cd3f0e8 Compare June 11, 2026 07:47
@Subhooo5

Copy link
Copy Markdown
Contributor Author

Thanks for the PR. I have to request changes. You added an accessibility test suite for 'utils/urls.ts' testing ARIA relationships and focus visibility. A URL construction utility file does not render HTML or manage DOM focus, so it cannot have ARIA attributes. Please target accessibility tests only at valid UI components (.tsx).

File updated successfully, All tests pass locally, feel free to review & add necessary labels. 🚀

@Aamod-Dev Aamod-Dev added level:intermediate Moderate complexity tasks quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. labels Jun 11, 2026

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together. The changes are clean and the logic looks sound. The accessibility improvements and ARIA attribute coverage look great and will really help screen reader users. Approved!

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together. The code looks clean and solves the issue effectively.

I'm happy to approve this. Great job!

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. I went through the changes and the overall approach looks good, but there are a few issues that should be addressed before this can be merged. Most of the concerns are related to correctness and maintainability.

  • There are merge conflicts with the base branch. Please resolve them to ensure existing functionality isn't broken.

Once these issues are addressed, I'll be happy to take another look. Thanks again for the contribution.

@Aamod-Dev Aamod-Dev removed the level:beginner Small changes Usually isolated fixes or simple UI/text updates. label Jun 12, 2026

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. It looks like there are merge conflicts with the base branch. Please rebase and resolve the conflicts so we can proceed with testing and merging. Thanks!

@github-actions github-actions Bot added the status:blocked This PR is blocked due to a failing CI check. label Jun 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚨 Hey @Subhooo5, the CI Pipeline is failing on this PR and it has been marked as status:blocked.

Please fix the issues before this can be reviewed. Here's how:

1. Run checks locally before pushing:

npm run format:check   # Check Prettier formatting
npm run lint           # Run ESLint
npm run typecheck      # TypeScript type check
npm run test           # Run unit tests (Vitest)
npm run build          # Verify production build passes

2. Auto-fix common issues:

npm run format         # Auto-fix formatting with Prettier
npm run lint -- --fix  # Auto-fix lint errors where possible

3. Check the full failure log here:
👉 View CI Run

Once you push a fix and the CI passes, the status:blocked label will be removed automatically. 💪

@Subhooo5 Subhooo5 closed this Jun 12, 2026
@Subhooo5 Subhooo5 deleted the test/urls-accessibility-compliance branch June 12, 2026 08:43
@Subhooo5

Copy link
Copy Markdown
Contributor Author

Hey @Aamod007 @JhaSourav07 Due to excessive confusion and mixups I closed this PR and have created a new fresh PR #5363 for issue #4661. Kindly review, add necessary labels and merge #5363 at the earliest to avoid further merge conflicts. 🫂🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:needs-rebase GSSoC 2026 level:intermediate Moderate complexity tasks mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. status:blocked This PR is blocked due to a failing CI check.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(urls-accessibility): verify Accessibility Standards & Screen Reader Aria Compliance (Variation 4)

3 participants