test(EditorPanel-theme-contrast): add dark/light visual cohesion test coverage#5184
Conversation
|
@kanishka-2007-tech is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
🚨 Hey @kanishka-2007-tech, the CI Pipeline is failing on this PR and it has been marked as Please fix the issues before this can be reviewed. Here's how: 1. Run checks locally before pushing: npm run format:check # Check Prettier formatting
npm run lint # Run ESLint
npm run typecheck # TypeScript type check
npm run test # Run unit tests (Vitest)
npm run build # Verify production build passes2. Auto-fix common issues: npm run format # Auto-fix formatting with Prettier
npm run lint -- --fix # Auto-fix lint errors where possible3. Check the full failure log here: Once you push a fix and the CI passes, the |
1b3c960 to
beae30f
Compare
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for submitting this PR. I've reviewed the code and everything looks solid. The theme contrast test cases ensure our UI remains cohesive in both light and dark modes. Approved!
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for putting this together. The code looks clean and solves the issue effectively.
I'm happy to approve this. Great job!
There was a problem hiding this comment.
Thanks for the PR! The test suite looks great, but the CI pipeline is currently failing due to a TypeScript type mismatch. The \GeneratorState\ interface in the main codebase was recently updated, so your mock state in \app/generator/components/EditorPanel.theme-contrast.test.tsx\ is now missing a few required properties.
To fix the CI error, please add \showSnakeGraph: false, \showPacmanGraph: false, and \graphPlacement: 'bottom'\ to the \defaultProps.state\ object at the top of your test file. Once that's added, the CI should pass and we can get this merged!
4e217a7 to
e305572
Compare
|
Review Update |
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for fixing the CI pipeline! Approving.
|
🎉 Congratulations @kanishka-2007-tech! Your PR has been successfully merged. 🚀 Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.
Keep building! 💻✨ |
Description
Adds a dedicated theme contrast test suite for EditorPanel to validate Dark and Light Prefers-Color-Scheme visual cohesion requirements.
The test suite focuses on the GitHub import CTA and verifies that light and dark theme styling classes remain present and consistent across theme configurations.
Changes
Added
app/generator/components/EditorPanel.theme-contrast.test.tsx
Test Coverage
Fixes #4462
Pillar
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.