Skip to content

test(EditorPanel-theme-contrast): add dark/light visual cohesion test coverage#5184

Merged
JhaSourav07 merged 1 commit into
JhaSourav07:mainfrom
kanishka-2007-tech:editorpanel
Jun 12, 2026
Merged

test(EditorPanel-theme-contrast): add dark/light visual cohesion test coverage#5184
JhaSourav07 merged 1 commit into
JhaSourav07:mainfrom
kanishka-2007-tech:editorpanel

Conversation

@kanishka-2007-tech

@kanishka-2007-tech kanishka-2007-tech commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Description

Adds a dedicated theme contrast test suite for EditorPanel to validate Dark and Light Prefers-Color-Scheme visual cohesion requirements.

The test suite focuses on the GitHub import CTA and verifies that light and dark theme styling classes remain present and consistent across theme configurations.

Changes

Added
app/generator/components/EditorPanel.theme-contrast.test.tsx

Test Coverage

  • Verifies the GitHub import button renders correctly.
  • Verifies light-theme contrast styling is present.
  • Verifies dark-theme contrast styling is present.
  • Verifies contrast-aware text styling for the import label.
  • Verifies hover and visual cohesion classes are configured for both themes.

Fixes #4462

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
  • I have updated README.md if I added a new theme or URL parameter.
  • I have started the repo.
  • I have made sure that i have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
  • (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

@vercel

vercel Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@kanishka-2007-tech is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the status:blocked This PR is blocked due to a failing CI check. label Jun 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚨 Hey @kanishka-2007-tech, the CI Pipeline is failing on this PR and it has been marked as status:blocked.

Please fix the issues before this can be reviewed. Here's how:

1. Run checks locally before pushing:

npm run format:check   # Check Prettier formatting
npm run lint           # Run ESLint
npm run typecheck      # TypeScript type check
npm run test           # Run unit tests (Vitest)
npm run build          # Verify production build passes

2. Auto-fix common issues:

npm run format         # Auto-fix formatting with Prettier
npm run lint -- --fix  # Auto-fix lint errors where possible

3. Check the full failure log here:
👉 View CI Run

Once you push a fix and the CI passes, the status:blocked label will be removed automatically. 💪

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR. I've reviewed the code and everything looks solid. The theme contrast test cases ensure our UI remains cohesive in both light and dark modes. Approved!

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together. The code looks clean and solves the issue effectively.

I'm happy to approve this. Great job!

@Aamod-Dev Aamod-Dev added level:beginner Small changes Usually isolated fixes or simple UI/text updates. type:test labels Jun 12, 2026

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The test suite looks great, but the CI pipeline is currently failing due to a TypeScript type mismatch. The \GeneratorState\ interface in the main codebase was recently updated, so your mock state in \app/generator/components/EditorPanel.theme-contrast.test.tsx\ is now missing a few required properties.

To fix the CI error, please add \showSnakeGraph: false, \showPacmanGraph: false, and \graphPlacement: 'bottom'\ to the \defaultProps.state\ object at the top of your test file. Once that's added, the CI should pass and we can get this merged!

@github-actions github-actions Bot removed the status:blocked This PR is blocked due to a failing CI check. label Jun 12, 2026
@Aamod-Dev Aamod-Dev added the quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. label Jun 12, 2026
@Aamod-Dev

Copy link
Copy Markdown
Collaborator

Review Update
Automatically adjusted labels to meet the strict 1:1:1:1:1 category requirement.

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the CI pipeline! Approving.

@JhaSourav07 JhaSourav07 added the gssoc:approved PR has been reviewed and accepted for valid contribution points label Jun 12, 2026
@JhaSourav07 JhaSourav07 merged commit 9a55681 into JhaSourav07:main Jun 12, 2026
6 of 7 checks passed
@github-actions github-actions Bot added this to the GSSoC 2026 milestone Jun 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🎉 Congratulations @kanishka-2007-tech! Your PR has been successfully merged. 🚀

Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.

⚠️ Important for GSSoC Contributors:
You are strictly advised to join our Discord Server as it is mandatory for all GSSoC participants. All important announcements, point claims, and community discussions happen there.

Keep building! 💻✨

@kanishka-2007-tech kanishka-2007-tech deleted the editorpanel branch June 14, 2026 06:33
@github-actions github-actions Bot added type:testing Adding, updating, or fixing tests and removed type:test labels Jun 15, 2026
@JhaSourav07 JhaSourav07 added gssoc:approved PR has been reviewed and accepted for valid contribution points and removed gssoc:approved PR has been reviewed and accepted for valid contribution points labels Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved PR has been reviewed and accepted for valid contribution points GSSoC 2026 level:beginner Small changes Usually isolated fixes or simple UI/text updates. mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:testing Adding, updating, or fixing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(EditorPanel-theme-contrast): verify Dark and Light Prefers-Color-Scheme Visual Cohesion (Variation 3)

3 participants