Skip to content

Test/successguide theme contrast#5186

Closed
sanzzzz-g wants to merge 5 commits into
JhaSourav07:mainfrom
sanzzzz-g:test/successguide-theme-contrast
Closed

Test/successguide theme contrast#5186
sanzzzz-g wants to merge 5 commits into
JhaSourav07:mainfrom
sanzzzz-g:test/successguide-theme-contrast

Conversation

@sanzzzz-g

Copy link
Copy Markdown
Contributor

Description

Fixes #4448

Adds theme contrast coverage for the SuccessGuide component to verify visual cohesion across dark and light color schemes.

This PR introduces isolated tests that validate Tailwind dark-mode styling, readable foreground contrast, and consistent interactive UI behavior in both preferred color schemes.

Changes Made

  • added SuccessGuide.theme-contrast.test.tsx
  • verified dark and light theme container styling
  • validated readable text contrast classes across themes
  • checked button and interactive element theme states
  • ensured overlay/background layers preserve foreground readability
  • mocked animation dependencies for deterministic rendering
  • added isolated visual cohesion assertions for Tailwind dark mode classes

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

N/A (test-only changes)

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format.
  • I have updated README.md if needed.
  • I have started the repo.
  • I have made sure that i have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard.
  • I joined the CommitPulse Discord community.

@sanzzzz-g sanzzzz-g force-pushed the test/successguide-theme-contrast branch from 35d323a to 447b24d Compare June 11, 2026 08:32
@github-actions github-actions Bot added status:blocked This PR is blocked due to a failing CI check. and removed status:blocked This PR is blocked due to a failing CI check. labels Jun 11, 2026

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the contribution! I went through the implementation and it meets our expectations. The theme contrast test cases ensure our UI remains cohesive in both light and dark modes. Happy to approve this.

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate you taking the time to submit this PR. I went through the implementation and the approach looks solid.

Everything looks good. Approving this now.

@Aamod-Dev Aamod-Dev added type:testing Adding, updating, or fixing tests level:beginner Small changes Usually isolated fixes or simple UI/text updates. quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. labels Jun 13, 2026

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is currently marked with the \status:blocked\ label. Please resolve the blockers so we can proceed with a full review and approval.

@Aamod-Dev Aamod-Dev added level:advanced Complex contributions involving architecture, optimization, or significant feature work quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:design UI designs, styling, SVG icons, and themes and removed level:beginner Small changes Usually isolated fixes or simple UI/text updates. quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. labels Jun 13, 2026

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I went through the changes and have evaluated them according to the rubric.

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the issues that caused the blocked label before this can be approved.

@sanzzzz-g sanzzzz-g force-pushed the test/successguide-theme-contrast branch from d4a3c20 to 72f7d66 Compare June 14, 2026 07:14
@sanzzzz-g

Copy link
Copy Markdown
Contributor Author

Yeah @Aamod007 All checks are passed now!

@sanzzzz-g sanzzzz-g requested a review from Aamod-Dev June 14, 2026 07:29

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is currently blocked due to a failing CI check or other blocking issues. Please fix the blocking issues so we can proceed with the review and approval process.

@sanzzzz-g

Copy link
Copy Markdown
Contributor Author

But all checks are passed now

@sanzzzz-g sanzzzz-g force-pushed the test/successguide-theme-contrast branch 2 times, most recently from 9059b3a to 6c6ee8c Compare June 15, 2026 06:22
@github-actions github-actions Bot removed the status:blocked This PR is blocked due to a failing CI check. label Jun 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Size Report (Gzipped Sizes)

✨ No significant bundle size changes detected.

📊 Summary of Totals

Category PR Size Base Size Difference
Total JS 3433.84 KB 3433.84 KB 0 B
Total CSS 258.05 KB 258.05 KB 0 B

@sanzzzz-g sanzzzz-g requested a review from Aamod-Dev June 15, 2026 06:40
@sanzzzz-g

Copy link
Copy Markdown
Contributor Author

Hey @Aamod007 All the checks are passed now!

@sanzzzz-g sanzzzz-g force-pushed the test/successguide-theme-contrast branch from 6c6ee8c to a07592e Compare June 16, 2026 05:41
@sanzzzz-g sanzzzz-g closed this by deleting the head repository Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GSSoC 2026 level:advanced Complex contributions involving architecture, optimization, or significant feature work mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:design UI designs, styling, SVG icons, and themes type:testing Adding, updating, or fixing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(SuccessGuide-theme-contrast): verify Dark and Light Prefers-Color-Scheme Visual Cohesion (Variation 3)

2 participants