Test/successguide theme contrast#5186
Conversation
35d323a to
447b24d
Compare
Aamod-Dev
left a comment
There was a problem hiding this comment.
Appreciate the contribution! I went through the implementation and it meets our expectations. The theme contrast test cases ensure our UI remains cohesive in both light and dark modes. Happy to approve this.
Aamod-Dev
left a comment
There was a problem hiding this comment.
Appreciate you taking the time to submit this PR. I went through the implementation and the approach looks solid.
Everything looks good. Approving this now.
Aamod-Dev
left a comment
There was a problem hiding this comment.
This PR is currently marked with the \status:blocked\ label. Please resolve the blockers so we can proceed with a full review and approval.
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I went through the changes and have evaluated them according to the rubric.
Aamod-Dev
left a comment
There was a problem hiding this comment.
Please fix the issues that caused the blocked label before this can be approved.
d4a3c20 to
72f7d66
Compare
|
Yeah @Aamod007 All checks are passed now! |
Aamod-Dev
left a comment
There was a problem hiding this comment.
This PR is currently blocked due to a failing CI check or other blocking issues. Please fix the blocking issues so we can proceed with the review and approval process.
|
But all checks are passed now |
9059b3a to
6c6ee8c
Compare
📦 Next.js Bundle Size Report (Gzipped Sizes)✨ No significant bundle size changes detected. 📊 Summary of Totals
|
|
Hey @Aamod007 All the checks are passed now! |
Removed assertions for 'Technology Dependency Graph' in multiple test cases.
6c6ee8c to
a07592e
Compare
Description
Fixes #4448
Adds theme contrast coverage for the
SuccessGuidecomponent to verify visual cohesion across dark and light color schemes.This PR introduces isolated tests that validate Tailwind dark-mode styling, readable foreground contrast, and consistent interactive UI behavior in both preferred color schemes.
Changes Made
SuccessGuide.theme-contrast.test.tsxPillar
Visual Preview
N/A (test-only changes)
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).README.mdif needed.