test(useGlowEffect): verify dark and light color scheme contrast visual cohesion (#4501)#5283
Merged
JhaSourav07 merged 3 commits intoJun 12, 2026
Conversation
Contributor
Author
|
@Aamod007 @JhaSourav07 PR is ready for #4501 |
Aamod-Dev
approved these changes
Jun 12, 2026
Aamod-Dev
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for putting this together. The code looks clean and solves the issue effectively.
Looks solid. I'll go ahead and approve.
Contributor
|
🎉 Congratulations @atharv96k! Your PR has been successfully merged. 🚀 Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.
Keep building! 💻✨ |
Collaborator
|
Review Summary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧩 Background
This PR addresses Issue #4501, focusing on establishing robust, isolated unit and integration validation checking targeting Dark and Light Prefers-Color-Scheme Visual Cohesion inside the styling hook layer of
hooks/useGlowEffect.ts.🎯 Objective
Introduces a brand-new, dependency-free test file
hooks/useGlowEffect.theme-contrast.test.tsto ensure that active background styles, shadow parameters, and text layer contrasts satisfy standard WCAG parameters under dual-theme shifts without introducing environment-dependent test execution drops.🛠️ Implementation Details
shadow-glow-dark,shadow-glow-light) register smoothly.✅ Definition of Done
vitest run useGlowEffect.theme-contrastpasses perfectly (5/5).npx tsc --noEmitruns completely clean with zero type errors.npm run lintclears with 0 errors across target files.Fixes #4501