Skip to content

fix: sanitize username input in generateNotFoundSVG to prevent SVG in… #5298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JhaSourav07 merged 6 commits into from
Jun 12, 2026
Merged

fix: sanitize username input in generateNotFoundSVG to prevent SVG in… #5298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0232b86
Merge branch 'main' into fix/svg-injection-not-found-username
taniy8 Jun 11, 2026
7c01288
fix: sanitize username input in generateNotFoundSVG to prevent SVG in…
taniy8 Jun 11, 2026
be54dc6
Merge branch 'main' into fix/svg-injection-not-found-username
taniy8 Jun 11, 2026
3f55fa6
Merge branch 'main' into fix/svg-injection-not-found-username
taniy8 Jun 12, 2026
4d9fd86
fix: sanitize username input in generateNotFoundSVG to prevent SVG in…
taniy8 Jun 12, 2026
8c68706
Merge branch 'main' into fix/svg-injection-not-found-username
taniy8 Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/svg/generator.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,7 +685,7 @@ describe('generateSVG', () => {

it('renders the username in uppercase and escapes XML-reserved characters', () => {
const svg = generateNotFoundSVG('octocat&co', '#0d1117', '#00ffaa', '#ffffff', 8);
expect(svg).toContain('OCTOCAT&CO');
expect(svg).toContain('OCTOCATCO');
});

it('displays the "NOT FOUND" text label', () => {
Expand Down
3 changes: 2 additions & 1 deletion lib/svg/generator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1971,7 +1971,8 @@ export function generateNotFoundSVG(
radius: number,
speed: string = '8s'
): string {
const safeName = escapeXML(username.toUpperCase());
const sanitizedUsername = username.replace(/[^a-zA-Z0-9\-]/g, '').slice(0, 39) || 'unknown';
const safeName = escapeXML(sanitizedUsername.toUpperCase());
const ghostTowersHtml = renderGhostTowers(GHOST_LAYOUT, accent);

const safeId = safeName.replace(/[^a-zA-Z0-9-]/g, '_').toLowerCase();
Expand Down
Loading