Skip to content

test: add theme contrast tests for TopMetricsRow#5299

Merged
JhaSourav07 merged 4 commits into
JhaSourav07:mainfrom
gamana618:topmetricsrow-theme-contrast-test
Jun 13, 2026
Merged

test: add theme contrast tests for TopMetricsRow#5299
JhaSourav07 merged 4 commits into
JhaSourav07:mainfrom
gamana618:topmetricsrow-theme-contrast-test

Conversation

@gamana618

Copy link
Copy Markdown
Contributor

Description

Fixes #4491

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
  • I have updated README.md if I added a new theme or URL parameter.
  • I have started the repo.
  • I have made sure that i have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
  • (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

@vercel

vercel Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@gamana618 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the status:blocked This PR is blocked due to a failing CI check. label Jun 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚨 Hey @gamana618, the CI Pipeline is failing on this PR and it has been marked as status:blocked.

Please fix the issues before this can be reviewed. Here's how:

1. Run checks locally before pushing:

npm run format:check   # Check Prettier formatting
npm run lint           # Run ESLint
npm run typecheck      # TypeScript type check
npm run test           # Run unit tests (Vitest)
npm run build          # Verify production build passes

2. Auto-fix common issues:

npm run format         # Auto-fix formatting with Prettier
npm run lint -- --fix  # Auto-fix lint errors where possible

3. Check the full failure log here:
👉 View CI Run

Once you push a fix and the CI passes, the status:blocked label will be removed automatically. 💪

@Aamod-Dev Aamod-Dev added quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. level:beginner Small changes Usually isolated fixes or simple UI/text updates. labels Jun 12, 2026

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. It looks like a good start, but there are a few areas that could use some refinement to ensure long-term maintainability. Let's get these sorted out.

  • The current implementation does not handle null or undefined values strictly in some data manipulation methods, which may lead to runtime issues in edge cases. Adding optional chaining or explicit null checks would make it more robust.

Once these issues are addressed, I'll be happy to take another look. Thanks again for the contribution.

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I've reviewed the changes and they look good to me.

No concerns from my end. Approved.

@Aamod-Dev Aamod-Dev added mentor:Aamod007 level:intermediate Moderate complexity tasks quality:exceptional Outstanding contribution with exceptional implementation quality, testing. type:feature New features, additions, or enhancements type:testing Adding, updating, or fixing tests labels Jun 12, 2026

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. I went through the changes and everything looks solid. The code is readable, well-structured, and aligns with the project conventions.

Justifying the quality:exceptional label: you went meaningfully beyond the ask by including robust tests and handling edge cases, reducing future tech debt. Great engineering work here!

I'll go ahead and approve this PR. Thanks again for the contribution!

@Aamod-Dev Aamod-Dev removed the level:beginner Small changes Usually isolated fixes or simple UI/text updates. label Jun 12, 2026
@gamana618

Copy link
Copy Markdown
Contributor Author

Thanks for the PR. It looks like a good start, but there are a few areas that could use some refinement to ensure long-term maintainability. Let's get these sorted out.

  • The current implementation does not handle null or undefined values strictly in some data manipulation methods, which may lead to runtime issues in edge cases. Adding optional chaining or explicit null checks would make it more robust.

Once these issues are addressed, I'll be happy to take another look. Thanks again for the contribution.

Thanks for the review! I'll update the implementation to handle null and undefined values more defensively by adding appropriate checks/optional chaining where needed. I'll push the changes shortly.

@github-actions github-actions Bot removed the status:blocked This PR is blocked due to a failing CI check. label Jun 12, 2026
@Aamod-Dev Aamod-Dev removed the quality:exceptional Outstanding contribution with exceptional implementation quality, testing. label Jun 13, 2026
@Aamod-Dev Aamod-Dev added GSSoC 2026 gssoc:approved PR has been reviewed and accepted for valid contribution points labels Jun 13, 2026
@github-actions github-actions Bot added this to the GSSoC 2026 milestone Jun 13, 2026
@gamana618

gamana618 commented Jun 13, 2026

Copy link
Copy Markdown
Contributor Author

Hi @Aamod007,

Thank you for reviewing and approving the PR. I noticed that it has been approved but not merged yet. Could you please let me know if any further changes are required from my side before it can be merged?

Thank you!

@JhaSourav07 JhaSourav07 merged commit 0ffaad7 into JhaSourav07:main Jun 13, 2026
7 of 8 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🎉 Congratulations @gamana618! Your PR has been successfully merged. 🚀

Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.

⚠️ Important for GSSoC Contributors:
You are strictly advised to join our Discord Server as it is mandatory for all GSSoC participants. All important announcements, point claims, and community discussions happen there.

Keep building! 💻✨

@JhaSourav07 JhaSourav07 added gssoc:approved PR has been reviewed and accepted for valid contribution points and removed gssoc:approved PR has been reviewed and accepted for valid contribution points labels Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved PR has been reviewed and accepted for valid contribution points GSSoC 2026 level:intermediate Moderate complexity tasks mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:feature New features, additions, or enhancements type:testing Adding, updating, or fixing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(TopMetricsRow-theme-contrast): verify Dark and Light Prefers-Color-Scheme Visual Cohesion (Variation 3)

3 participants