fix: improve keyboard accessibility for resume upload dropzone#5304
Conversation
|
@krishpatel2-prog is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
🚨 Hey @krishpatel2-prog, the CI Pipeline is failing on this PR and it has been marked as Please fix the issues before this can be reviewed. Here's how: 1. Run checks locally before pushing: npm run format:check # Check Prettier formatting
npm run lint # Run ESLint
npm run typecheck # TypeScript type check
npm run test # Run unit tests (Vitest)
npm run build # Verify production build passes2. Auto-fix common issues: npm run format # Auto-fix formatting with Prettier
npm run lint -- --fix # Auto-fix lint errors where possible3. Check the full failure log here: Once you push a fix and the CI passes, the |
d17611f to
d676e5b
Compare
|
@Aamod007 I noticed that my PR has been automatically marked with My changes are limited to:
The ResumeUpload accessibility tests are passing successfully. The failing checks appear to come from I also noticed that several recent PRs seem to have received the same |
Aamod-Dev
left a comment
There was a problem hiding this comment.
I appreciate the attention to detail here. The changes make sense and fit well with our current structure.
The changes are straightforward and don't seem to introduce any regressions. The implementation follows the established patterns nicely.
Everything looks good. Approving this now.
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I've taken a look at the changes and everything seems to align with what we need here.
Everything looks good. Approving this now.
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I went through the changes and the overall approach looks good. The keyboard accessibility enhancements for the resume dropzone are well implemented, and adding tests to verify keyboard interactions is a great touch. I'll go ahead and approve this PR. Thanks again for the contribution.
|
🎉 Congratulations @krishpatel2-prog! Your PR has been successfully merged. 🚀 Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.
Keep building! 💻✨ |
📌 Description
Fixes #5292
This PR improves the accessibility of the Resume Upload component by making the visible upload dropzone keyboard-accessible.
Previously, the upload area relied only on mouse interactions. Keyboard users could not activate the visible dropzone using standard keys such as Enter or Space, which limited usability and accessibility.
✨ Changes Made
♿ Improved keyboard accessibility
Added keyboard interaction support to the visible upload dropzone.
The upload area now behaves like an interactive control and can be activated using:
Preserved existing:
🧪 Accessibility test coverage
Extended the existing accessibility tests to verify:
🎯 Why this change?
This improves accessibility for:
while keeping the implementation small and preserving all existing functionality.
📂 Files Modified
components/dashboard/ResumeUpload.tsxcomponents/dashboard/ResumeUpload.accessibility.test.tsxPillar
Visual Preview
N/A – accessibility enhancement ♿
✅ Checklist before requesting a review
CONTRIBUTING.mdfile.