\test(cacheControl): add empty-fallback test and robust options param…#5306
Conversation
|
🚨 Hey @ShafinNigamana, the CI Pipeline is failing on this PR and it has been marked as Please fix the issues before this can be reviewed. Here's how: 1. Run checks locally before pushing: npm run format:check # Check Prettier formatting
npm run lint # Run ESLint
npm run typecheck # TypeScript type check
npm run test # Run unit tests (Vitest)
npm run build # Verify production build passes2. Auto-fix common issues: npm run format # Auto-fix formatting with Prettier
npm run lint -- --fix # Auto-fix lint errors where possible3. Check the full failure log here: Once you push a fix and the CI passes, the |
ce43a23 to
6c66f1c
Compare
6c66f1c to
3e47e5a
Compare
Aamod-Dev
left a comment
There was a problem hiding this comment.
Good work on this one. I reviewed the diff and it looks ready to go from my side.
The test coverage added here looks comprehensive and well-structured. It definitely improves the reliability of the system.
Looks solid. I'll go ahead and approve.
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for the PR. I've reviewed the changes and they look good to me.
No concerns from my end. Approved.
|
🎉 Congratulations @ShafinNigamana! Your PR has been successfully merged. 🚀 Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.
Keep building! 💻✨ |
|
Review Summary |
Description
Adds a robust empty-fallback test suite for
utils/cacheControl.tsand refactors thebuildCacheControlHeaderfunction to safely handle missing ornull/undefinedoption parameters without crashing.Fixes #4304
Pillar
Visual Preview
N/A — Purely a logic / unit testing update. No visual changes.
Checklist before requesting a review:
CONTRIBUTING.mdfile.npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.