fix: rename middleware.ts to proxy.ts (Next.js 16.2.7 deprecation)#5315
Conversation
|
@Kokila-chandrakar is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
🚨 Hey @Kokila-chandrakar, the CI Pipeline is failing on this PR and it has been marked as Please fix the issues before this can be reviewed. Here's how: 1. Run checks locally before pushing: npm run format:check # Check Prettier formatting
npm run lint # Run ESLint
npm run typecheck # TypeScript type check
npm run test # Run unit tests (Vitest)
npm run build # Verify production build passes2. Auto-fix common issues: npm run format # Auto-fix formatting with Prettier
npm run lint -- --fix # Auto-fix lint errors where possible3. Check the full failure log here: Once you push a fix and the CI passes, the |
Aamod-Dev
left a comment
There was a problem hiding this comment.
I've reviewed the PR and while the functionality seems to be there, I have a few concerns regarding the implementation details. Let's address these before moving forward.
- This is quite a large PR. While the changes seem generally okay, this logic somewhat duplicates existing functionality already present in other modules. Reusing shared utilities would help keep the codebase consistent. Could we look into breaking this down or refactoring?
Once these issues are addressed, I'll be happy to take another look. Thanks again for the contribution.
Aamod-Dev
left a comment
There was a problem hiding this comment.
Good work on this one. I reviewed the diff and it looks ready to go from my side.
Looks solid. I'll go ahead and approve.
|
🎉 Congratulations @Kokila-chandrakar! Your PR has been successfully merged. 🚀 Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.
Keep building! 💻✨ |
Description
Fixes #4839
Renames
middleware.tstoproxy.tsand updates the exported function name frommiddlewaretoproxyas required by Next.js 16.2.7 deprecation. Also updatesmiddleware.test.tstoproxy.test.tswith correct imports.Pillar
Visual Preview
No visual changes — file rename and import updates only.
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.