Skip to content

test(CustomizeCTA-theme-contrast): verify dark and light prefers-color-scheme visual cohesion#5322

Merged
JhaSourav07 merged 2 commits into
JhaSourav07:mainfrom
aanyacloud:test/customizecta-theme-contrast
Jun 20, 2026
Merged

test(CustomizeCTA-theme-contrast): verify dark and light prefers-color-scheme visual cohesion#5322
JhaSourav07 merged 2 commits into
JhaSourav07:mainfrom
aanyacloud:test/customizecta-theme-contrast

Conversation

@aanyacloud

Copy link
Copy Markdown
Contributor

Fixes #4444

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕒 Pillar 3 — Timezone Logic Optimization
  • 🛠 Other (Bug fix, refactoring, docs)

Visual Preview

N/A (test-only changes)

Summary

Added theme contrast test coverage for CustomizeCTA to verify dark and light prefers-color-scheme visual cohesion.

Tests Added

  • Verifies light and dark background classes on the CTA card
  • Verifies theme-aware heading text colors
  • Verifies theme-aware badge color styling
  • Verifies theme-aware border styling
  • Verifies button contrast styling for visibility in both themes

Checklist before requesting a review

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally.
  • I have run the relevant test suite and verified it passes.
  • My commits follow the Conventional Commits format.
  • I have made sure that I have only one commit in this PR.

Test Results

Test Files  1 passed (1)
Tests       5 passed (5)

@github-actions github-actions Bot added the status:blocked This PR is blocked due to a failing CI check. label Jun 12, 2026
@Aamod-Dev Aamod-Dev added level:beginner Small changes Usually isolated fixes or simple UI/text updates. quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:testing Adding, updating, or fixing tests type:design UI designs, styling, SVG icons, and themes type:accessibility Accessibility (a11y) improvements and screen reader fixes mentor:Aamod007 labels Jun 12, 2026

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. I went through the changes and the overall approach looks good. The theme contrast test cases are clearly structured and properly test the component styling. However, I noticed that the CI pipeline is currently failing for this PR.

  • The \Format · Lint · Typecheck · Test\ CI job has failed. Please run
    pm run format,
    pm run lint, and
    pm run test\ locally to identify and resolve the issue.

Once these issues are addressed and the CI is green, I'll be happy to take another look and get this merged. Thanks again for the contribution.

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. The overall approach looks good, but the CI pipeline is currently failing. Please run the checks (like npm run format, npm run lint, and npm run test) locally to identify and fix the issues. Let me know once it's green!

@Aamod-Dev Aamod-Dev added gssoc:approved PR has been reviewed and accepted for valid contribution points and removed type:design UI designs, styling, SVG icons, and themes type:accessibility Accessibility (a11y) improvements and screen reader fixes labels Jun 12, 2026
@Aamod-Dev

Copy link
Copy Markdown
Collaborator

Review Update
Automatically adjusted labels to meet the strict 1:1:1:1:1 category requirement.

@github-actions github-actions Bot added this to the GSSoC 2026 milestone Jun 12, 2026
@Aamod-Dev Aamod-Dev added GSSoC 2026 type:design UI designs, styling, SVG icons, and themes labels Jun 13, 2026

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is currently marked with the \status:blocked\ label. Please resolve the blockers so we can proceed with a full review and approval.

@Aamod-Dev Aamod-Dev added level:advanced Complex contributions involving architecture, optimization, or significant feature work quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. and removed level:beginner Small changes Usually isolated fixes or simple UI/text updates. quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. labels Jun 13, 2026

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I went through the changes and have evaluated them according to the rubric.

@JhaSourav07 JhaSourav07 removed the gssoc:approved PR has been reviewed and accepted for valid contribution points label Jun 13, 2026

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the issues that caused the blocked label before this can be approved.

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is currently blocked due to a failing CI check or other blocking issues. Please fix the blocking issues so we can proceed with the review and approval process.

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test addition is straightforward, but the PR is still blocked, so I’m keeping it on Request Changes for now. Please clear the failing/blocking check first, then I can re-run the review on the actual test coverage in �pp/components/CustomizeCTA.theme-contrast.test.tsx.

@Aamod-Dev Aamod-Dev added the level:intermediate Moderate complexity tasks label Jun 18, 2026

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Difficulty: intermediate – Test coverage expansion.

Quality: clean – Good tests.

Type: testing – Quality improvement.

Good tests!

@github-actions github-actions Bot removed the status:blocked This PR is blocked due to a failing CI check. label Jun 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Size Report (Gzipped Sizes)

✨ No significant bundle size changes detected.

📊 Summary of Totals

Category PR Size Base Size Difference
Total JS 3649.55 KB 3649.55 KB 0 B
Total CSS 287.99 KB 287.99 KB 0 B

@JhaSourav07 JhaSourav07 added the gssoc:approved PR has been reviewed and accepted for valid contribution points label Jun 20, 2026
@JhaSourav07 JhaSourav07 merged commit 06cba58 into JhaSourav07:main Jun 20, 2026
5 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🎉 Congratulations @aanyacloud! Your PR has been successfully merged. 🚀

Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.

⚠️ Important for GSSoC Contributors:
You are strictly advised to join our Discord Server as it is mandatory for all GSSoC participants. All important announcements, point claims, and community discussions happen there.

Keep building! 💻✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved PR has been reviewed and accepted for valid contribution points GSSoC 2026 level:advanced Complex contributions involving architecture, optimization, or significant feature work level:intermediate Moderate complexity tasks mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:design UI designs, styling, SVG icons, and themes type:testing Adding, updating, or fixing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(CustomizeCTA-theme-contrast): verify Dark and Light Prefers-Color-Scheme Visual Cohesion (Variation 3)

3 participants