Skip to content

perf: Add SHA1 ETag caching and 304 Status response for Compare API#5332

Merged
JhaSourav07 merged 1 commit into
JhaSourav07:mainfrom
MasterJi27:perf-etag-compare-5242
Jun 12, 2026
Merged

perf: Add SHA1 ETag caching and 304 Status response for Compare API#5332
JhaSourav07 merged 1 commit into
JhaSourav07:mainfrom
MasterJi27:perf-etag-compare-5242

Conversation

@MasterJi27

Copy link
Copy Markdown
Contributor

Resolves #5242. Generates SHA1 ETag for the compare API JSON payload, sets ETag and Cache-Control headers, and returns a 304 Not Modified status response if the client's If-None-Match matches.

Copilot AI review requested due to automatic review settings June 12, 2026 06:44
@vercel

vercel Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@MasterJi27 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Aamod-Dev Aamod-Dev added level:intermediate Moderate complexity tasks type:performance Code changes that improve performance/speed quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. mentor:Aamod007 labels Jun 12, 2026

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. I went through the changes and the overall approach looks good. The implementation for ETag caching and returning a 304 Not Modified status is clean and correctly includes tests.

Labels Applied:

  • \level:intermediate: The PR introduces caching logic via ETag handling for the API endpoint, requiring cross-file updates and understanding of HTTP caching mechanisms.
  • \ ype:performance: The primary purpose of this PR is to improve API performance by adding caching.
  • \quality:clean: The code is readable, follows project style, and includes comprehensive test coverage for the new caching behavior.
  • \mentor:Aamod007\

Once again, great work on this performance optimization!

@JhaSourav07 JhaSourav07 added the gssoc:approved PR has been reviewed and accepted for valid contribution points label Jun 12, 2026
@JhaSourav07 JhaSourav07 merged commit db695cb into JhaSourav07:main Jun 12, 2026
9 of 10 checks passed
@github-actions github-actions Bot added this to the GSSoC 2026 milestone Jun 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🎉 Congratulations @MasterJi27! Your PR has been successfully merged. 🚀

Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.

⚠️ Important for GSSoC Contributors:
You are strictly advised to join our Discord Server as it is mandatory for all GSSoC participants. All important announcements, point claims, and community discussions happen there.

Keep building! 💻✨

@JhaSourav07 JhaSourav07 added gssoc:approved PR has been reviewed and accepted for valid contribution points and removed gssoc:approved PR has been reviewed and accepted for valid contribution points labels Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved PR has been reviewed and accepted for valid contribution points level:intermediate Moderate complexity tasks mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:performance Code changes that improve performance/speed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

perf: Add SHA1 ETag caching and 304 Status response for Compare API

4 participants