Skip to content

bug: Align historical year ranges to user timezone offsets#5338

Merged
JhaSourav07 merged 3 commits into
JhaSourav07:mainfrom
MasterJi27:bug-year-ranges-5259
Jun 12, 2026
Merged

bug: Align historical year ranges to user timezone offsets#5338
JhaSourav07 merged 3 commits into
JhaSourav07:mainfrom
MasterJi27:bug-year-ranges-5259

Conversation

@MasterJi27

Copy link
Copy Markdown
Contributor

Resolves #5259. Aligns the query bounds from and to parameter values with timezone offset boundaries by converting local midnight and local end-of-day timestamps to UTC when fetching historical year contribution calendars.

Copilot AI review requested due to automatic review settings June 12, 2026 07:25
@vercel

vercel Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@MasterJi27 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added the status:blocked This PR is blocked due to a failing CI check. label Jun 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚨 Hey @MasterJi27, the CI Pipeline is failing on this PR and it has been marked as status:blocked.

Please fix the issues before this can be reviewed. Here's how:

1. Run checks locally before pushing:

npm run format:check   # Check Prettier formatting
npm run lint           # Run ESLint
npm run typecheck      # TypeScript type check
npm run test           # Run unit tests (Vitest)
npm run build          # Verify production build passes

2. Auto-fix common issues:

npm run format         # Auto-fix formatting with Prettier
npm run lint -- --fix  # Auto-fix lint errors where possible

3. Check the full failure log here:
👉 View CI Run

Once you push a fix and the CI passes, the status:blocked label will be removed automatically. 💪

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Timezone offsets are notoriously tricky to handle without heavy external libraries, but your use of Intl.DateTimeFormat to parse parts and calculate the offset milliseconds is very clever and lightweight.

The tests verifying the offset against Honolulu timezone perfectly validate the boundaries.

Labels Applied:

  • level:intermediate: Timezone offset calculation using Intl parsing is moderately complex.
  • type:bug: Fixes issue #5259 with year bounds.
  • quality:clean: Clean, native implementation without adding heavy dependencies, and includes tests.
  • gssoc:approved
  • mentor:Aamod007

@Aamod-Dev Aamod-Dev added level:intermediate Moderate complexity tasks type:bug Something isn't working as expected quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. gssoc:approved PR has been reviewed and accepted for valid contribution points mentor:Aamod007 labels Jun 12, 2026
@github-actions github-actions Bot added this to the GSSoC 2026 milestone Jun 12, 2026
@github-actions github-actions Bot removed the status:blocked This PR is blocked due to a failing CI check. label Jun 12, 2026
@MasterJi27

Copy link
Copy Markdown
Contributor Author

Hi @sauravjha, @Aamod007 all required checks have passed and the PR has been approved. The remaining Vercel check appears to require team authorization. Could you please review and merge when convenient? Thanks

@MasterJi27 MasterJi27 force-pushed the bug-year-ranges-5259 branch from 9df19bc to d0c2417 Compare June 12, 2026 19:23
@MasterJi27 MasterJi27 requested a review from Aamod-Dev June 12, 2026 19:50
@JhaSourav07 JhaSourav07 merged commit eb1e604 into JhaSourav07:main Jun 12, 2026
5 of 6 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🎉 Congratulations @MasterJi27! Your PR has been successfully merged. 🚀

Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.

⚠️ Important for GSSoC Contributors:
You are strictly advised to join our Discord Server as it is mandatory for all GSSoC participants. All important announcements, point claims, and community discussions happen there.

Keep building! 💻✨

@JhaSourav07 JhaSourav07 added gssoc:approved PR has been reviewed and accepted for valid contribution points and removed gssoc:approved PR has been reviewed and accepted for valid contribution points labels Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved PR has been reviewed and accepted for valid contribution points gssoc:needs-rebase level:intermediate Moderate complexity tasks mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:bug Something isn't working as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Align historical year ranges to user timezone offsets

4 participants