test(ApiPr-insightsRoute-theme-contrast): verify Dark and Light Prefers-Color-Scheme Visual Cohesion

[adityack477]

Description

Closes #4435

What changed

• Created new file app/api/pr-insights/route.theme-contrast.test.ts with 5 test cases

Test cases

1. Returns identical data structure regardless of dark or light prefers-color-scheme header
2. Returns numeric stat fields suitable for color-coded badges in both themes
3. Returns highlight fields with title and url required for accessible link contrast styling
4. Returns consistent error response and Content-Type regardless of theme headers
5. Returns repoPerformance array with mergeRate values usable for progress bar contrast styling in both themes

How it works

Since route.ts is a server-side API with no rendered UI, theme contrast is interpreted as the API being theme-agnostic: it must return identical, well-typed data regardless of the client's color scheme so the frontend can apply correct light/dark contrast styling.

• Mocks fetchPRInsights to return a deterministic PR insights payload
• Verifies dark vs light prefers-color-scheme headers produce identical JSON responses
• Confirms numeric stat fields (mergeRate, totalPRs, etc.) used for color-coded badges
• Checks highlight objects contain title/url needed for accessible link styling
• Validates error responses are consistent across themes
• Asserts repoPerformance mergeRate values stay within 0-100 for progress bar rendering

Tests

All 5 new tests pass. All existing tests pass.

Pillar

• 🎨 Pillar 1 — New Theme Design
• 📐 Pillar 2 — Geometric SVG Improvement
• 🕐 Pillar 3 — Timezone Logic Optimization
• 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

Checklist before requesting a review:

• I have read the CONTRIBUTING.md file.
• I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
• I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
• My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
• I have updated README.md if I added a new theme or URL parameter.
• I have started the repo.
• I have made sure that i have only one commit to merge in this PR.
• The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
• (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

[adityack477]

@souravjhahind pls review and add labels

[Aamod-Dev]

Thanks for the PR. However, testing 'Visual Cohesion' and 'theme contrast' on a backend API route that only returns JSON data is not a meaningful use of unit tests. The sec-ch-prefers-color-scheme header has no effect on this API, so asserting that the JSON output is identical does not provide any real testing value. Please focus on testing actual business logic (like error handling, data parsing, or the actual GitHub API mock responses) rather than theme contrast for an API route. Please rewrite these tests to cover meaningful API logic.

Labels Applied:

• level:beginner: These are simple mock tests.
• type:testing: Testing PR.
• quality:clean: Code is syntactically fine, but conceptually flawed.
• gssoc:invalid: Conceptually invalid test scenario.
• mentor:Aamod007

[adityack477]

Thanks for the PR. However, testing 'Visual Cohesion' and 'theme contrast' on a backend API route that only returns JSON data is not a meaningful use of unit tests. The sec-ch-prefers-color-scheme header has no effect on this API, so asserting that the JSON output is identical does not provide any real testing value. Please focus on testing actual business logic (like error handling, data parsing, or the actual GitHub API mock responses) rather than theme contrast for an API route. Please rewrite these tests to cover meaningful API logic.

Labels Applied:

• level:beginner: These are simple mock tests.
• type:testing: Testing PR.
• quality:clean: Code is syntactically fine, but conceptually flawed.
• gssoc:invalid: Conceptually invalid test scenario.
• mentor:Aamod007

Thanks for the feedback you are right, theme contrast doesn't make sense for a JSON API.
I have rewritten the test suite to focus on actual business logic in route.ts
Pls review now and let me know if there's anything else you would like adjusted.

[Aamod-Dev]

The updated tests now correctly test the business logic, error handling, and parameter validation. Thanks for updating it! Approving.

[github-actions]

🎉 Congratulations @adityack477! Your PR has been successfully merged. 🚀

Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.

⚠️ Important for GSSoC Contributors:
You are strictly advised to join our Discord Server as it is mandatory for all GSSoC participants. All important announcements, point claims, and community discussions happen there.

Keep building! 💻✨