Skip to content

Test(DashboardError): add empty-fallback edge case tests#5366

Merged
JhaSourav07 merged 3 commits into
JhaSourav07:mainfrom
diksha78dev:fix/issue-4196
Jun 13, 2026
Merged

Test(DashboardError): add empty-fallback edge case tests#5366
JhaSourav07 merged 3 commits into
JhaSourav07:mainfrom
diksha78dev:fix/issue-4196

Conversation

@diksha78dev

Copy link
Copy Markdown
Contributor

Description

Fixes #4196

Adds app/(root)/dashboard/error.empty-fallback.test.tsx with 5 isolated tests focusing on edge cases, empty strings, and missing inputs in the DashboardError component:

  • Verifies that a generic ⚠️ emoji is rendered when error.message is an empty string.
  • Verifies that the default fallback description string is used when error.message is an empty string.
  • Verifies that the generic 'Something went wrong' heading is displayed.
  • Verifies that the component renders without throwing runtime errors when the optional digest field is absent on the error object.
  • Verifies that both the Try again button and Go back home link are present in the DOM when displaying the fallback UI.

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

(N/A - This PR only introduces test suite coverage and does not modify the visual layout or codebase components.)

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally.
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format.
  • I have updated README.md if I added a new theme or URL parameter.
  • I have starred the repo.
  • I have made sure that i have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
  • (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

The PR follows a known pattern of AI-generated superficial test files or inappropriate modifications that provide little to no meaningful runtime coverage and clutter the repository.

Required Changes

Issue 1

  • Problem: The test file creates or simulates interactions on dummy structures, or simply adds redundant tests.
  • Impact: It provides 0 real test coverage.
  • Required Fix: Ensure the PR tests actual new runtime behavior and does not just add redundant tests.

@Aamod-Dev Aamod-Dev added GSSoC 2026 mentor:Aamod007 type:testing Adding, updating, or fixing tests level:beginner Small changes Usually isolated fixes or simple UI/text updates. quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. labels Jun 12, 2026
@Aamod-Dev Aamod-Dev added the gssoc:approved PR has been reviewed and accepted for valid contribution points label Jun 13, 2026
@github-actions github-actions Bot added this to the GSSoC 2026 milestone Jun 13, 2026
@github-actions github-actions Bot added the status:blocked This PR is blocked due to a failing CI check. label Jun 13, 2026
@github-actions github-actions Bot removed the status:blocked This PR is blocked due to a failing CI check. label Jun 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Size Report (Gzipped Sizes)

✨ No significant bundle size changes detected.

📊 Summary of Totals

Category PR Size Base Size Difference
Total JS 3405.30 KB 3405.30 KB 0 B
Total CSS 252.94 KB 252.94 KB 0 B

@JhaSourav07 JhaSourav07 merged commit ff10f80 into JhaSourav07:main Jun 13, 2026
5 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🎉 Congratulations @diksha78dev! Your PR has been successfully merged. 🚀

Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.

⚠️ Important for GSSoC Contributors:
You are strictly advised to join our Discord Server as it is mandatory for all GSSoC participants. All important announcements, point claims, and community discussions happen there.

Keep building! 💻✨

@JhaSourav07 JhaSourav07 added gssoc:approved PR has been reviewed and accepted for valid contribution points and removed gssoc:approved PR has been reviewed and accepted for valid contribution points labels Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved PR has been reviewed and accepted for valid contribution points gssoc:needs-rebase GSSoC 2026 level:beginner Small changes Usually isolated fixes or simple UI/text updates. mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:testing Adding, updating, or fixing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(DashboardError-empty-fallback): verify Edge Cases & Empty/Missing Inputs Verification (Variation 1)

3 participants