Skip to content

Test(dashboard): handle empty error fallbacks safely#5369

Merged
JhaSourav07 merged 1 commit into
JhaSourav07:mainfrom
diksha78dev:fix/issue-4199
Jun 13, 2026
Merged

Test(dashboard): handle empty error fallbacks safely#5369
JhaSourav07 merged 1 commit into
JhaSourav07:mainfrom
diksha78dev:fix/issue-4199

Conversation

@diksha78dev

Copy link
Copy Markdown
Contributor

Description

Fixes #4199. Resolves a crash in the dashboard error boundary component when rendering null, undefined, empty, or malformed error objects by ensuring proper fallback checks.

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs) - Safeguards/Unit test coverage

Visual Preview

N/A — Logic and testing update only. No visual elements changed.

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (npx vitest run "app/(root)/dashboard/error.empty-fallback.test.tsx" "app/(root)/dashboard/error.test.tsx").
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
  • I have updated README.md if I added a new theme or URL parameter. (N/A — no theme or URL parameters added)
  • I have starred the repo.
  • I have made sure that i have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts). (N/A — no SVG code modified)
  • (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

@github-actions github-actions Bot added the status:blocked This PR is blocked due to a failing CI check. label Jun 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚨 Hey @diksha78dev, the CI Pipeline is failing on this PR and it has been marked as status:blocked.

Please fix the issues before this can be reviewed. Here's how:

1. Run checks locally before pushing:

npm run format:check   # Check Prettier formatting
npm run lint           # Run ESLint
npm run typecheck      # TypeScript type check
npm run test           # Run unit tests (Vitest)
npm run build          # Verify production build passes

2. Auto-fix common issues:

npm run format         # Auto-fix formatting with Prettier
npm run lint -- --fix  # Auto-fix lint errors where possible

3. Check the full failure log here:
👉 View CI Run

Once you push a fix and the CI passes, the status:blocked label will be removed automatically. 💪

@github-actions github-actions Bot removed the status:blocked This PR is blocked due to a failing CI check. label Jun 12, 2026
@Aamod-Dev Aamod-Dev added type:testing Adding, updating, or fixing tests level:beginner Small changes Usually isolated fixes or simple UI/text updates. quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. labels Jun 13, 2026
@Aamod-Dev Aamod-Dev added GSSoC 2026 gssoc:approved PR has been reviewed and accepted for valid contribution points labels Jun 13, 2026
@github-actions github-actions Bot added this to the GSSoC 2026 milestone Jun 13, 2026
@JhaSourav07 JhaSourav07 merged commit fe0158b into JhaSourav07:main Jun 13, 2026
10 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🎉 Congratulations @diksha78dev! Your PR has been successfully merged. 🚀

Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.

⚠️ Important for GSSoC Contributors:
You are strictly advised to join our Discord Server as it is mandatory for all GSSoC participants. All important announcements, point claims, and community discussions happen there.

Keep building! 💻✨

@JhaSourav07 JhaSourav07 added gssoc:approved PR has been reviewed and accepted for valid contribution points and removed gssoc:approved PR has been reviewed and accepted for valid contribution points labels Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved PR has been reviewed and accepted for valid contribution points GSSoC 2026 level:beginner Small changes Usually isolated fixes or simple UI/text updates. quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:testing Adding, updating, or fixing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(ApiGithubRoute-empty-fallback): verify Edge Cases & Empty/Missing Inputs Verification (Variation 1)

3 participants