Skip to content

Test rate limit accessibility 4631#5389

Merged
JhaSourav07 merged 4 commits into
JhaSourav07:mainfrom
buildwithnisha:test-rate-limit-accessibility-4631
Jun 12, 2026
Merged

Test rate limit accessibility 4631#5389
JhaSourav07 merged 4 commits into
JhaSourav07:mainfrom
buildwithnisha:test-rate-limit-accessibility-4631

Conversation

@buildwithnisha

Copy link
Copy Markdown
Contributor

Description

Fixes #4631

Summary

  • Added accessibility tests for rate-limit utility
  • Covered rate limit result structure
  • Tested allowlist and blocklist behavior
  • Verified rate limit response fields for accessibility consumers

Testing

  • Ran:
    npm test -- lib/rate-limit.accessibility.test.ts

Conflict resolution

  • Resolved merge conflicts with the latest changes from main
  • Verified tests still pass after resolving conflicts

Updated branch with latest main.

Checked:

  • git fetch origin
  • git merge origin/main
  • Tests passing locally

No conflicts found on local branch.

Fixes #4631

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

N/A

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
  • I have updated README.md if I added a new theme or URL parameter.
  • I have started the repo.
  • I have made sure that i have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
  • (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

@vercel

vercel Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@buildwithnisha is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the status:blocked This PR is blocked due to a failing CI check. label Jun 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚨 Hey @buildwithnisha, the CI Pipeline is failing on this PR and it has been marked as status:blocked.

Please fix the issues before this can be reviewed. Here's how:

1. Run checks locally before pushing:

npm run format:check   # Check Prettier formatting
npm run lint           # Run ESLint
npm run typecheck      # TypeScript type check
npm run test           # Run unit tests (Vitest)
npm run build          # Verify production build passes

2. Auto-fix common issues:

npm run format         # Auto-fix formatting with Prettier
npm run lint -- --fix  # Auto-fix lint errors where possible

3. Check the full failure log here:
👉 View CI Run

Once you push a fix and the CI passes, the status:blocked label will be removed automatically. 💪

@github-actions github-actions Bot removed the status:blocked This PR is blocked due to a failing CI check. label Jun 12, 2026
@Aamod-Dev Aamod-Dev added GSSoc26 GSSoC 2026 level:critical High-priority or mission-critical contributions affecting core systems, security, or infrastructure quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:testing Adding, updating, or fixing tests type:accessibility Accessibility (a11y) improvements and screen reader fixes type:security Security fixes, dependency updates, or hardening mentor:Aamod007 and removed GSSoc26 labels Jun 12, 2026

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. I went through the changes and the overall approach looks good.

@JhaSourav07 JhaSourav07 added the gssoc:approved PR has been reviewed and accepted for valid contribution points label Jun 12, 2026
@JhaSourav07 JhaSourav07 merged commit 5bb167f into JhaSourav07:main Jun 12, 2026
13 of 14 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🎉 Congratulations @buildwithnisha! Your PR has been successfully merged. 🚀

Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.

⚠️ Important for GSSoC Contributors:
You are strictly advised to join our Discord Server as it is mandatory for all GSSoC participants. All important announcements, point claims, and community discussions happen there.

Keep building! 💻✨

@github-actions github-actions Bot added this to the GSSoC 2026 milestone Jun 12, 2026
@JhaSourav07 JhaSourav07 added gssoc:approved PR has been reviewed and accepted for valid contribution points and removed gssoc:approved PR has been reviewed and accepted for valid contribution points labels Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved PR has been reviewed and accepted for valid contribution points GSSoC 2026 level:critical High-priority or mission-critical contributions affecting core systems, security, or infrastructure mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:accessibility Accessibility (a11y) improvements and screen reader fixes type:security Security fixes, dependency updates, or hardening type:testing Adding, updating, or fixing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(rate-limit-accessibility): verify Accessibility Standards & Screen Reader Aria Compliance (Variation 4)

3 participants