fix: restore missing feature cards in Why CommitPulse section#5396
Conversation
|
@devansh6107 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for restoring the missing feature cards in the 'Why CommitPulse' section! It looks much better now with the complete set of cards rendering correctly.
Your code is perfect. However, the CI pipeline will currently fail due to an unrelated test divergence in lib/svg/themes.test.ts on the main branch.
To get a green build, simply run git pull --rebase origin main and force push your branch. I'll be ready to merge once that runs!
Labels Applied:
level:beginner: Simple DOM rendering and component usage.type:bug: Restored missing content.quality:clean: Flawless syntax.mentor:Aamod007
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I went through the changes and the overall approach looks good.
459b7e2 to
abe6e02
Compare
|
🚨 Hey @devansh6107, the CI Pipeline is failing on this PR and it has been marked as Please fix the issues before this can be reviewed. Here's how: 1. Run checks locally before pushing: npm run format:check # Check Prettier formatting
npm run lint # Run ESLint
npm run typecheck # TypeScript type check
npm run test # Run unit tests (Vitest)
npm run build # Verify production build passes2. Auto-fix common issues: npm run format # Auto-fix formatting with Prettier
npm run lint -- --fix # Auto-fix lint errors where possible3. Check the full failure log here: Once you push a fix and the CI passes, the |
|
🎉 Congratulations @devansh6107! Your PR has been successfully merged. 🚀 Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.
Keep building! 💻✨ |
Aamod-Dev
left a comment
There was a problem hiding this comment.
Good catch! I went through the changes and restoring the missing feature cards brings back the essential informational elements of the landing page.
Labels applied:
- level:intermediate: Layout restoration.
- quality:clean: Simple effective DOM fix.
- ype:bug: Fixes missing UI elements.
Description
Fixes #5372
Restored the missing feature cards in the "Why CommitPulse?" section on the landing page.
Restored the three feature cards:
Restored the corresponding icons for each feature card.
Moved
WallOfLovebelow the feature cards section.Pillar
Visual Preview
Before: The "Why CommitPulse?" section displayed only the heading, with the feature cards missing.
After: The three feature cards are rendered correctly and the Wall of Love section appears below them.
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.