[codex] fix strict GitHub username validation#5398
Conversation
|
Someone is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
👋 Hey @saurabhhhcodes! Thanks for your contribution! 🎉 Unfortunately, this PR has been automatically closed because it is not linked to any open issue. To resolve this, please do the following:
We look forward to reviewing your PR once an issue is linked! 🚀 |
Aamod-Dev
left a comment
There was a problem hiding this comment.
Solid validation fix! I went through the changes and ensuring GitHub username validations accurately match GitHub's internal regex prevents rejected input for valid usernames.
Labels applied:
- level:intermediate: Regex parsing validation.
- quality:clean: Accurate boundary adjustments.
- ype:bug: Fixes input routing.
Description\n\nTighten GitHub username validation so it matches GitHub's 39-character limit and rejects invalid leading/trailing hyphen patterns.\n\n## Validation\n\n- npm test -- --run lib/validations.accessibility.test.ts lib/validations.githubParamsSchema.test.ts lib/validations.streakParamsSchema.test.ts lib/validations.massive-scaling.test.ts\n- git diff --check