Skip to content

[codex] fix strict GitHub username validation#5398

Closed
saurabhhhcodes wants to merge 1 commit into
JhaSourav07:mainfrom
saurabhhhcodes:codex/strict-username-validation
Closed

[codex] fix strict GitHub username validation#5398
saurabhhhcodes wants to merge 1 commit into
JhaSourav07:mainfrom
saurabhhhcodes:codex/strict-username-validation

Conversation

@saurabhhhcodes

Copy link
Copy Markdown
Contributor

Description\n\nTighten GitHub username validation so it matches GitHub's 39-character limit and rejects invalid leading/trailing hyphen patterns.\n\n## Validation\n\n- npm test -- --run lib/validations.accessibility.test.ts lib/validations.githubParamsSchema.test.ts lib/validations.streakParamsSchema.test.ts lib/validations.massive-scaling.test.ts\n- git diff --check

@vercel

vercel Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Someone is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Hey @saurabhhhcodes! Thanks for your contribution! 🎉

Unfortunately, this PR has been automatically closed because it is not linked to any open issue.

To resolve this, please do the following:

  1. Link a valid open issue by editing your PR description to include a closing keyword (e.g., Fixes #<issue-number>).
  2. Reopen this PR once the link is added.

💡 You can link multiple issues if needed (e.g. Fixes #12, Closes #34).
If you're working on something that doesn't have an issue yet, please open one first and then link it here.

We look forward to reviewing your PR once an issue is linked! 🚀

@github-actions github-actions Bot closed this Jun 12, 2026
@Aamod-Dev Aamod-Dev added mentor:Aamod007 level:intermediate Moderate complexity tasks quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:bug Something isn't working as expected labels Jun 14, 2026

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid validation fix! I went through the changes and ensuring GitHub username validations accurately match GitHub's internal regex prevents rejected input for valid usernames.
Labels applied:

  • level:intermediate: Regex parsing validation.
  • quality:clean: Accurate boundary adjustments.
  • ype:bug: Fixes input routing.

@Aamod-Dev Aamod-Dev added GSSoC 2026 gssoc:approved PR has been reviewed and accepted for valid contribution points labels Jun 14, 2026
@github-actions github-actions Bot added this to the GSSoC 2026 milestone Jun 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved PR has been reviewed and accepted for valid contribution points GSSoC 2026 level:intermediate Moderate complexity tasks mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:bug Something isn't working as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants