Verify edge cases and input validation for tracking fallback by realtushartyagi · Pull Request #5399 · JhaSourav07/commitpulse

realtushartyagi · 2026-06-12T14:02:08Z

Description

Fixes #4309

This PR Adds empty-input and fallback tests for utils/tracking.ts.

Pillar

🎨 Pillar 1 — New Theme Design
📐 Pillar 2 — Geometric SVG Improvement
🕐 Pillar 3 — Timezone Logic Optimization
🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

N/A (Integration Test update)

Checklist before requesting a review:

I have read the CONTRIBUTING.md file.
I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
I have updated README.md if I added a new theme or URL parameter.
I have started the repo.
I have made sure that i have only one commit to merge in this PR.
The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
(Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

vercel · 2026-06-12T14:02:12Z

@realtushartyagi is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds Vitest coverage for trackUser edge cases, focusing on empty-username no-ops and runtime fallbacks between navigator.sendBeacon and fetch.

Changes:

Introduces a new test suite validating empty input short-circuit behavior.
Adds tests for server/headless execution safety (missing window/navigator).
Adds tests for sendBeacon absence/failure and fetch fallback error handling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+  beforeEach(() => {
+    originalWindow = globalThis.window;
+    originalNavigator = globalThis.navigator;
+    originalFetch = globalThis.fetch;
+    originalBlob = globalThis.Blob;
+
+    globalThis.window = {} as unknown as typeof globalThis.window;
+    globalThis.navigator = {
+      sendBeacon: vi.fn().mockReturnValue(true),
+    } as unknown as typeof globalThis.navigator;
+    globalThis.fetch = vi.fn().mockResolvedValue({ ok: true });


+    // Ensure Blob is polyfilled securely to prevent hydration or runtime errors in CI
+    if (typeof globalThis.Blob === 'undefined') {
+      globalThis.Blob = class Blob {
+        constructor(
+          public parts: string[],
+          public options: Record<string, string>
+        ) {}
+      } as unknown as typeof globalThis.Blob;
+    }


+    // Wait a tick to ensure async catch block executes cleanly
+    await new Promise(process.nextTick);


Aamod-Dev

Thanks for adding the edge case coverage for the tracking fallback! Ensuring sendBeacon queuing failures properly route to the fetch API prevents silent telemetry loss, which is great.

Your test coverage is perfect. However, you will notice the CI pipeline is currently failing due to an unrelated divergence in lib/svg/themes.test.ts on the main branch.

To secure a green build, simply run git pull --rebase origin main and force push your branch. I'll be ready to approve once that runs!

Labels Applied:

level:beginner: Standard API fallback testing.
type:testing: Edge case validation.
quality:clean: Excellent isolation of network limits.
mentor:Aamod007

…ts Verification

Aamod-Dev

Great job resolving the issues! The pipeline divergence is fixed and the code looks completely solid. Approved! 🎉

Aamod-Dev

Great job resolving the issues! The pipeline divergence is fixed and the code looks completely solid. Approved! 🎉

Aamod-Dev

Thanks for the contribution. I went through the changes and the overall approach looks good.

github-actions · 2026-06-12T20:37:29Z

🎉 Congratulations @realtushartyagi! Your PR has been successfully merged. 🚀

Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.

⚠️ Important for GSSoC Contributors:
You are strictly advised to join our Discord Server as it is mandatory for all GSSoC participants. All important announcements, point claims, and community discussions happen there.

Keep building! 💻✨

Aamod-Dev

Looks great! I went through the changes and ensuring tracking edge cases are verified makes the telemetry pipeline much safer.
Labels applied:

level:advanced: Complex input verification.
quality:clean: Robust coverage.
ype:feature: Feature telemetry testing.

Copilot AI review requested due to automatic review settings June 12, 2026 14:02

Copilot AI reviewed Jun 12, 2026

View reviewed changes

Aamod-Dev requested changes Jun 12, 2026

View reviewed changes

test(tracking-empty-fallback): verify Edge Cases & Empty/Missing Inpu…

b7bdd54

…ts Verification

realtushartyagi force-pushed the test/tracking-empty-fallback branch from d511419 to b7bdd54 Compare June 12, 2026 18:56

Aamod-Dev approved these changes Jun 12, 2026

View reviewed changes

JhaSourav07 added the gssoc:approved PR has been reviewed and accepted for valid contribution points label Jun 12, 2026

JhaSourav07 merged commit e76bd9e into JhaSourav07:main Jun 12, 2026
11 checks passed

github-actions Bot added this to the GSSoC 2026 milestone Jun 12, 2026

Aamod-Dev approved these changes Jun 14, 2026

View reviewed changes

github-actions Bot added type:testing Adding, updating, or fixing tests and removed type:feature New features, additions, or enhancements labels Jun 15, 2026

JhaSourav07 added gssoc:approved PR has been reviewed and accepted for valid contribution points and removed gssoc:approved PR has been reviewed and accepted for valid contribution points labels Jun 17, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Verify edge cases and input validation for tracking fallback#5399

Verify edge cases and input validation for tracking fallback#5399
JhaSourav07 merged 1 commit into
JhaSourav07:mainfrom
realtushartyagi:test/tracking-empty-fallback

realtushartyagi commented Jun 12, 2026

Uh oh!

vercel Bot commented Jun 12, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Aamod-Dev left a comment

Uh oh!

Aamod-Dev left a comment

Uh oh!

Aamod-Dev left a comment

Uh oh!

Aamod-Dev left a comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 12, 2026

Uh oh!

Aamod-Dev left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		// Wait a tick to ensure async catch block executes cleanly
		await new Promise(process.nextTick);

Conversation

realtushartyagi commented Jun 12, 2026

Description

Pillar

Visual Preview

Checklist before requesting a review:

Uh oh!

vercel Bot commented Jun 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Aamod-Dev left a comment

Choose a reason for hiding this comment

Uh oh!

Aamod-Dev left a comment

Choose a reason for hiding this comment

Uh oh!

Aamod-Dev left a comment

Choose a reason for hiding this comment

Uh oh!

Aamod-Dev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 12, 2026

Uh oh!

Aamod-Dev left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants