Implement WAI-ARIA accordion accessibility patterns for SectionCard#5403
Conversation
|
@kanishka-2007-tech is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
🚨 Hey @kanishka-2007-tech, the CI Pipeline is failing on this PR and it has been marked as Please fix the issues before this can be reviewed. Here's how: 1. Run checks locally before pushing: npm run format:check # Check Prettier formatting
npm run lint # Run ESLint
npm run typecheck # TypeScript type check
npm run test # Run unit tests (Vitest)
npm run build # Verify production build passes2. Auto-fix common issues: npm run format # Auto-fix formatting with Prettier
npm run lint -- --fix # Auto-fix lint errors where possible3. Check the full failure log here: Once you push a fix and the CI passes, the |
74eac2b to
da91d19
Compare
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for the accessibility improvements. Implementing WAI-ARIA patterns correctly across multiple files is an important step. Applied labels: \level:intermediate\ (touches multiple files), \ ype:accessibility, \quality:clean.
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for implementing the WAI-ARIA accordion accessibility patterns for the SectionCard! Ensuring screen readers properly associate the toggle buttons with their collapsible regions is a huge accessibility win for the generator interface.
Your code looks absolutely perfect. However, you will notice the CI pipeline is currently failing due to an unrelated divergence in lib/svg/themes.test.ts that recently occurred natively on the main branch.
To fix this and secure a green build, simply run git pull --rebase origin main and force push your branch. I'll be ready to approve right after!
Labels Applied:
level:intermediate: ARIA state mapping across component trees.type:accessibility: WAI-ARIA pattern implementations.quality:clean: Excellent markup bindings.mentor:Aamod007
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I went through the changes and the overall approach looks good.
|
🎉 Congratulations @kanishka-2007-tech! Your PR has been successfully merged. 🚀 Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.
Keep building! 💻✨ |
Description
This PR improves the accessibility of the SectionCard component by implementing standard WAI-ARIA accordion patterns and updating the accessibility test suite to validate the new behavior.
Changes Made
SectionCard Accessibility Improvements
Editor panel Accessibility had section card components hence it is also improved
Fixes #5359
Pillar
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.