Skip to content

test: add theme contrast tests for AdvancedSettingsPanel#5405

Merged
JhaSourav07 merged 1 commit into
JhaSourav07:mainfrom
deepsikha-dash:issue-4452-advancedsettingspanel-theme-contrast
Jun 12, 2026
Merged

test: add theme contrast tests for AdvancedSettingsPanel#5405
JhaSourav07 merged 1 commit into
JhaSourav07:mainfrom
deepsikha-dash:issue-4452-advancedsettingspanel-theme-contrast

Conversation

@deepsikha-dash

Copy link
Copy Markdown
Contributor

Description

Added a new theme contrast test suite for AdvancedSettingsPanel.

Changes made
Created AdvancedSettingsPanel.theme-contrast.test.tsx
Added tests for light and dark theme styling consistency
Verified theme-aware classes on labels, controls, inputs, separators, and grace controls
Ensured visual cohesion between light and dark modes

Fixes #4452

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

N/A

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
  • I have updated README.md if I added a new theme or URL parameter.
  • I have started the repo.
  • I have made sure that i have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
  • (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

@vercel

vercel Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@deepsikha-dash is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Aamod-Dev Aamod-Dev added level:beginner Small changes Usually isolated fixes or simple UI/text updates. type:testing Adding, updating, or fixing tests quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. mentor:Aamod007 labels Jun 12, 2026

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding theme contrast tests for the AdvancedSettingsPanel. Single file additions like this help keep things stable. Applied labels: \level:beginner, \ ype:testing, \quality:clean.

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the theme contrast tests on the AdvancedSettingsPanel! Ensuring all our dimension inputs, separators, and text bindings correctly adopt the dark and light mode classes is awesome for visual consistency.

Your code is absolutely perfect! However, the CI pipeline is currently failing due to an unrelated divergence in lib/svg/themes.test.ts that occurred natively on the main branch.

To get a perfectly green build, just run git pull --rebase origin main and force push your branch.

Labels Applied:

  • level:beginner: Standard theme class validation.
  • type:testing: UI class coverage.
  • quality:clean: Excellent isolation of elements.
  • mentor:Aamod007

@Aamod-Dev Aamod-Dev added GSSoc26 GSSoC 2026 level:advanced Complex contributions involving architecture, optimization, or significant feature work type:feature New features, additions, or enhancements type:design UI designs, styling, SVG icons, and themes and removed GSSoc26 labels Jun 12, 2026

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. I went through the changes and the overall approach looks good.

@JhaSourav07 JhaSourav07 added the gssoc:approved PR has been reviewed and accepted for valid contribution points label Jun 12, 2026
@JhaSourav07 JhaSourav07 merged commit 9bba8c9 into JhaSourav07:main Jun 12, 2026
14 of 15 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🎉 Congratulations @deepsikha-dash! Your PR has been successfully merged. 🚀

Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.

⚠️ Important for GSSoC Contributors:
You are strictly advised to join our Discord Server as it is mandatory for all GSSoC participants. All important announcements, point claims, and community discussions happen there.

Keep building! 💻✨

@github-actions github-actions Bot added this to the GSSoC 2026 milestone Jun 12, 2026
@JhaSourav07 JhaSourav07 added gssoc:approved PR has been reviewed and accepted for valid contribution points and removed gssoc:approved PR has been reviewed and accepted for valid contribution points labels Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved PR has been reviewed and accepted for valid contribution points GSSoC 2026 level:advanced Complex contributions involving architecture, optimization, or significant feature work level:beginner Small changes Usually isolated fixes or simple UI/text updates. mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:design UI designs, styling, SVG icons, and themes type:feature New features, additions, or enhancements type:testing Adding, updating, or fixing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(AdvancedSettingsPanel-theme-contrast): verify Dark and Light Prefers-Color-Scheme Visual Cohesion (Variation 3)

3 participants