test: add theme contrast tests for AdvancedSettingsPanel#5405
Conversation
|
@deepsikha-dash is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for adding theme contrast tests for the AdvancedSettingsPanel. Single file additions like this help keep things stable. Applied labels: \level:beginner, \ ype:testing, \quality:clean.
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for the theme contrast tests on the AdvancedSettingsPanel! Ensuring all our dimension inputs, separators, and text bindings correctly adopt the dark and light mode classes is awesome for visual consistency.
Your code is absolutely perfect! However, the CI pipeline is currently failing due to an unrelated divergence in lib/svg/themes.test.ts that occurred natively on the main branch.
To get a perfectly green build, just run git pull --rebase origin main and force push your branch.
Labels Applied:
level:beginner: Standard theme class validation.type:testing: UI class coverage.quality:clean: Excellent isolation of elements.mentor:Aamod007
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I went through the changes and the overall approach looks good.
|
🎉 Congratulations @deepsikha-dash! Your PR has been successfully merged. 🚀 Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.
Keep building! 💻✨ |
Description
Added a new theme contrast test suite for AdvancedSettingsPanel.
Changes made
Created AdvancedSettingsPanel.theme-contrast.test.tsx
Added tests for light and dark theme styling consistency
Verified theme-aware classes on labels, controls, inputs, separators, and grace controls
Ensured visual cohesion between light and dark modes
Fixes #4452
Pillar
Visual Preview
N/A
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.