fix: report correct cache status for cold requests (#5503)

[vipul674]

Fixes #5503

Problem

The X-Cache-Status header reported HIT for all non-bypass requests, even cold/first-time requests where no cache entry existed. This was misleading because the data was freshly fetched from GitHub API, not served from cache.

Fix

Check if the cache had data before the fetch using contributionsCache.has(). Now correctly reports:

• MISS for cold requests (no cache entry)
• HIT for requests served from cache
• MISS for bypass requests

[vercel]

@vipul674 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

[vipul674]

@JhaSourav07 Ready for review.

[Aamod-Dev]

Difficulty: beginner – Fixes X-Cache-Status in route.ts by checking cache.has() before fetch, reports MISS for cold requests (5 additions, updates test).

Quality: clean – Simple correctness fix.

Type: bug – Fixes issue #5503, accurate cache reporting.

Good fix!

[Aamod-Dev]

Review

This PR cannot be approved in its current state due to blocking issues (status:blocked label, merge conflicts, needs-rebase label, and/or failing CI checks). Please resolve the blocking issues and re-request review.

Once unblocked, I'm happy to re-review! 💚

[vipul674]

@JhaSourav07 All CI checks passing! Fixed the failing tests.

What was wrong:

• route.test.ts, route.empty-fallback.test.ts, and route.mouse-interactivity.test.ts were missing mocks for contributionsCache and cacheKey added in the PR
• This caused 500 errors when route.ts tried to call contributionsCache.has()

Fix:

• Added contributionsCache: { has: vi.fn().mockResolvedValue(false) } and cacheKey: vi.fn().mockReturnValue('key') mocks to all 3 test files

CI: Format/Lint/Typecheck/Test pass | Production Build pass | CodeQL pass | Analyze pass

[github-actions]

📦 Next.js Bundle Size Report (Gzipped Sizes)

✨ No significant bundle size changes detected.

📊 Summary of Totals

Category	PR Size	Base Size	Difference
Total JS	3694.34 KB	3694.34 KB	0 B
Total CSS	296.06 KB	296.06 KB	0 B

[vipul674]

@Aamod-Dev All blocking issues resolved! CI is now fully passing.

• Format/Lint/Typecheck/Test: pass
• Production Build: pass
• CodeQL: pass
• Analyze: pass

Ready for re-review. 💚

[Aamod-Dev]

Fixing the cache reporting for cold requests is a great quality-of-life improvement for debugging API performance. Adding the mock for contributionsCache.has in the test files keeps the test suite robust. Approved!

[github-actions]

🎉 Congratulations @vipul674! Your PR has been successfully merged. 🚀

Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.

⚠️ Important for GSSoC Contributors:
You are strictly advised to join our Discord Server as it is mandatory for all GSSoC participants. All important announcements, point claims, and community discussions happen there.

Keep building! 💻✨