Skip to content

fix: add per-IP rate limiting to prevent GitHub quota exhaustion #5957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
taniy8 wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −0
Open

fix: add per-IP rate limiting to prevent GitHub quota exhaustion #5957

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5207ed0
fix(compare): add per-IP rate limiting to prevent GitHub quota exhaus…
taniy8 Jun 18, 2026
9fe41db
Merge branch 'main' into fix/compare-missing-rate-limit
taniy8 Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions app/api/compare/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ import { getFullDashboardData } from '@/lib/github';
import { getUserGitHubToken } from '@/lib/githubtoken';
import { compareParamsSchema } from '@/lib/validations';
import crypto from 'crypto';
import { getClientIp } from '@/utils/getClientIp';
import { RateLimiter } from '@/lib/rate-limit';

const compareLimiter = new RateLimiter(5, 60_000, 1);
export const revalidate = 3600;

function buildCompareFetchErrorResponse(user: string, reason: unknown): NextResponse {
Expand Down Expand Up @@ -51,6 +54,17 @@ function buildCompareFetchErrorResponse(user: string, reason: unknown): NextResp
}

export async function GET(request: Request) {
const ip = getClientIp(request);
const rateLimitKey =
ip && ip !== 'unknown' ? ip : `unknown:${request.headers.get('user-agent') ?? 'no-agent'}`;

if (!(await compareLimiter.check(rateLimitKey))) {
return NextResponse.json(
{ error: 'Too many requests. Please try again later.' },
{ status: 429 }
);
}

const { searchParams } = new URL(request.url);

const parseResult = compareParamsSchema.safeParse(Object.fromEntries(searchParams.entries()));
Expand Down
Loading