feat(ui): overhaul footer layout, typography gradient, and icons#5979
feat(ui): overhaul footer layout, typography gradient, and icons#5979darshiB27 wants to merge 4 commits into
Conversation
|
@darshiB27 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
🚨 Hey @darshiB27, the CI Pipeline is failing on this PR and it has been marked as Please fix the issues before this can be reviewed. Here's how: 1. Run checks locally before pushing: npm run format:check # Check Prettier formatting
npm run lint # Run ESLint
npm run typecheck # TypeScript type check
npm run test # Run unit tests (Vitest)
npm run build # Verify production build passes2. Auto-fix common issues: npm run format # Auto-fix formatting with Prettier
npm run lint -- --fix # Auto-fix lint errors where possible3. Check the full failure log here: Once you push a fix and the CI passes, the |
Aamod-Dev
left a comment
There was a problem hiding this comment.
Blocked PR - cannot approve. This PR has the status:blocked label indicating a failing CI check. The footer overhaul in �pp/components/Footer.tsx and related test updates look well-structured (gradient backgrounds, SVG icon paths, updated tests), but the blocking CI issue must be resolved before approval. Please address the failing checks and request re-review.
Aamod-Dev
left a comment
There was a problem hiding this comment.
Review
This PR cannot be approved in its current state due to blocking issues (status:blocked label, merge conflicts, needs-rebase label, and/or failing CI checks). Please resolve the blocking issues and re-request review.
Once unblocked, I'm happy to re-review! 💚
|
okay |
Aamod-Dev
left a comment
There was a problem hiding this comment.
The visual overhaul of the footer looks great, especially the typography gradient and new SVG icons. However, this PR is currently marked as blocked (likely due to failing checks or unaddressed requested changes). Please resolve the blocking issues so we can proceed with this UI update.
|
dear mentor , |
Description
Fixes #5972
Pillar
Visual Preview
Before -
After -
it now includes svg icons for socials and better visuals in the footer .
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.