fix: External image fallback may not work reliably because it overwrites src without guarding#6022
fix: External image fallback may not work reliably because it overwrites src without guarding#6022Aditya8369 wants to merge 6 commits into
Conversation
…tes src without guarding
|
@Aditya8369 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
🚨 Hey @Aditya8369, the CI Pipeline is failing on this PR and it has been marked as Please fix the issues before this can be reviewed. Here's how: 1. Run checks locally before pushing: npm run format:check # Check Prettier formatting
npm run lint # Run ESLint
npm run typecheck # TypeScript type check
npm run test # Run unit tests (Vitest)
npm run build # Verify production build passes2. Auto-fix common issues: npm run format # Auto-fix formatting with Prettier
npm run lint -- --fix # Auto-fix lint errors where possible3. Check the full failure log here: Once you push a fix and the CI passes, the |
Aamod-Dev
left a comment
There was a problem hiding this comment.
Hey @Aditya8369, this PR has a status:blocked label so I can't approve it for now. The onError fallback pattern looks good across all 7 components — CompareClient.tsx, LandingPageClient.tsx, ContributorsSearch.tsx, CommitPulseSection.tsx, Leaderboard.tsx, GithubWrapped.tsx, HallOfFame.tsx, and ProfileCard.tsx. The guard checking arget.src !== 'https://github.com/github.png' prevents infinite loops. Once the block is cleared, I'll be happy to re-review!
Aamod-Dev
left a comment
There was a problem hiding this comment.
Review
This PR cannot be approved in its current state due to blocking issues (status:blocked label, merge conflicts, needs-rebase label, and/or failing CI checks). Please resolve the blocking issues and re-request review.
Once unblocked, I'm happy to re-review! 💚
Aamod-Dev
left a comment
There was a problem hiding this comment.
While fixing the external image fallback src guarding is an important bug fix, this PR contains hundreds of lines of unrelated formatting changes that make the core fix difficult to review. Additionally, the PR is currently marked as blocked. Please resolve the blocking issues and revert the unrelated formatting changes.
closes #3607