fix: resolve lint warnings and ensure successful build#6055
fix: resolve lint warnings and ensure successful build#6055deepsikha-dash wants to merge 1 commit into
Conversation
|
@deepsikha-dash is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Review — PR #6055 (@deepsikha-dash)
Great work cleaning up the lint warnings across the codebase! This is a massive change touching ~90 files, and the fixes look correct overall — removing unused imports/vars like screen, AchievementLevelDef, currentStreak, e in catch bindings, console.log→console.info, etc.
Labels applied:
- level:intermediate — Wide codebase navigation (90+ files across lib/, components/, app/, etc.), but changes are mechanical pattern-based fixes
- quality:clean — Changes are straightforward and correct for their purpose
- type:refactor — Lint warning cleanup is a refactoring effort
Issues to address:
- Merge conflict — The PR has a conflict with \main. Please pull the latest main and resolve.
- *\lint.txt, \lint2.txt, \lint3.txt* — These lint output log files were committed along with the changes. They're build artifacts and shouldn't be part of the PR. Please remove them from the branch.
Once these are resolved, this should be good to go! 🚀
Aamod-Dev
left a comment
There was a problem hiding this comment.
Good work cleaning up the unused imports and fixing the console.log warnings — those changes in scripts/load-test.mjs, utils/time.theme-contrast.test.ts, and models/User.theme-contrast.test.ts are exactly right.
One thing though — lint3.txt is committed and that's a lint output logfile that shouldn't live in the repo. Could you remove it and add it to .gitignore (or just drop it)? The actual code fixes look great, just need that file gone before we can merge.
Aamod-Dev
left a comment
There was a problem hiding this comment.
Re-review after new commits. The code fixes (unused import removals, console.log→console.info, etc.) are great. However, the lint artifact files (lint.txt, lint2.txt, lint3.txt) are still committed in the branch — these were flagged in both previous reviews. Please remove all three from the branch. The actual code fixes are ready to merge once the artifact files are dropped.
bda6429 to
4132868
Compare
Aamod-Dev
left a comment
There was a problem hiding this comment.
Review Summary
Labels: Already applied (level:intermediate, quality:clean, type:bug, type:refactor, status:blocked, mentor:Aamod007)
Blocked status: This PR has a failing CI check (Format · Lint · Typecheck · Test) and Vercel deployment, plus the status:blocked label. Per review policy, approval is blocked until CI passes.
Assessment: The changes look reasonable — fixing lint warnings and build issues across many test files. Please address the failing CI checks (Format · Lint · Typecheck · Test) and re-request review once they pass.
Happy to re-review once the CI pipeline is green! 💚
4132868 to
973e7c3
Compare
973e7c3 to
6ed3005
Compare
📦 Next.js Bundle Size Report (Gzipped Sizes)
📊 Summary of Totals
|
Aamod-Dev
left a comment
There was a problem hiding this comment.
Thank you for the comprehensive cleanup! Resolving these unused variables and imports across the codebase, such as in app/api/achievements/route.ts and test files, helps keep our build logs clean and reduces technical debt. Great work. Approved!
Description
Resolved ESLint warnings and code smells across the codebase and ensured the project builds successfully.
Fixes #5360
Pillar
Visual Preview
N/A
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.