Skip to content

fix: resolve lint warnings and ensure successful build#6055

Open
deepsikha-dash wants to merge 1 commit into
JhaSourav07:mainfrom
deepsikha-dash:chore-5360-eslint-cleanup
Open

fix: resolve lint warnings and ensure successful build#6055
deepsikha-dash wants to merge 1 commit into
JhaSourav07:mainfrom
deepsikha-dash:chore-5360-eslint-cleanup

Conversation

@deepsikha-dash

Copy link
Copy Markdown
Contributor

Description

Resolved ESLint warnings and code smells across the codebase and ensured the project builds successfully.

Fixes #5360

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

N/A

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
  • I have updated README.md if I added a new theme or URL parameter.
  • I have started the repo.
  • I have made sure that i have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
  • (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

@vercel

vercel Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

@deepsikha-dash is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the type:bug Something isn't working as expected label Jun 19, 2026
@Aamod-Dev Aamod-Dev added level:intermediate Moderate complexity tasks quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:refactor Code changes that neither fix a bug nor add a feature mentor:Aamod007 labels Jun 20, 2026

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review — PR #6055 (@deepsikha-dash)

Great work cleaning up the lint warnings across the codebase! This is a massive change touching ~90 files, and the fixes look correct overall — removing unused imports/vars like screen, AchievementLevelDef, currentStreak, e in catch bindings, console.log→console.info, etc.

Labels applied:

  • level:intermediate — Wide codebase navigation (90+ files across lib/, components/, app/, etc.), but changes are mechanical pattern-based fixes
  • quality:clean — Changes are straightforward and correct for their purpose
  • type:refactor — Lint warning cleanup is a refactoring effort

Issues to address:

  1. Merge conflict — The PR has a conflict with \main. Please pull the latest main and resolve.
  2. *\lint.txt, \lint2.txt, \lint3.txt* — These lint output log files were committed along with the changes. They're build artifacts and shouldn't be part of the PR. Please remove them from the branch.

Once these are resolved, this should be good to go! 🚀

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work cleaning up the unused imports and fixing the console.log warnings — those changes in scripts/load-test.mjs, utils/time.theme-contrast.test.ts, and models/User.theme-contrast.test.ts are exactly right.

One thing though — lint3.txt is committed and that's a lint output logfile that shouldn't live in the repo. Could you remove it and add it to .gitignore (or just drop it)? The actual code fixes look great, just need that file gone before we can merge.

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review after new commits. The code fixes (unused import removals, console.log→console.info, etc.) are great. However, the lint artifact files (lint.txt, lint2.txt, lint3.txt) are still committed in the branch — these were flagged in both previous reviews. Please remove all three from the branch. The actual code fixes are ready to merge once the artifact files are dropped.

@deepsikha-dash deepsikha-dash force-pushed the chore-5360-eslint-cleanup branch from bda6429 to 4132868 Compare June 20, 2026 15:43
@github-actions github-actions Bot added the status:blocked This PR is blocked due to a failing CI check. label Jun 20, 2026

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Labels: Already applied (level:intermediate, quality:clean, type:bug, type:refactor, status:blocked, mentor:Aamod007)

Blocked status: This PR has a failing CI check (Format · Lint · Typecheck · Test) and Vercel deployment, plus the status:blocked label. Per review policy, approval is blocked until CI passes.

Assessment: The changes look reasonable — fixing lint warnings and build issues across many test files. Please address the failing CI checks (Format · Lint · Typecheck · Test) and re-request review once they pass.

Happy to re-review once the CI pipeline is green! 💚

@deepsikha-dash deepsikha-dash force-pushed the chore-5360-eslint-cleanup branch from 4132868 to 973e7c3 Compare June 20, 2026 18:30
@deepsikha-dash deepsikha-dash force-pushed the chore-5360-eslint-cleanup branch from 973e7c3 to 6ed3005 Compare June 20, 2026 19:18
@github-actions github-actions Bot removed the status:blocked This PR is blocked due to a failing CI check. label Jun 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Size Report (Gzipped Sizes)

Asset PR Size Base Size Difference Status
static/chunks/app/(root)/dashboard/[username]/page-[hash].js 40.99 KB 41.02 KB -0.03 KB (-0.08%) 🟢 Improvement
static/chunks/app/generator/page-[hash].js 26.23 KB 26.25 KB -0.03 KB (-0.10%) 🟢 Improvement

📊 Summary of Totals

Category PR Size Base Size Difference
Total JS 3693.82 KB 3694.34 KB -0.52 KB (-0.01%)
Total CSS 296.06 KB 296.06 KB 0 B

@Aamod-Dev Aamod-Dev added GSSoC 2026 level:advanced Complex contributions involving architecture, optimization, or significant feature work refactor bug Something isn't working labels Jun 21, 2026

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the comprehensive cleanup! Resolving these unused variables and imports across the codebase, such as in app/api/achievements/route.ts and test files, helps keep our build logs clean and reduces technical debt. Great work. Approved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working gssoc:needs-rebase GSSoC 2026 level:advanced Complex contributions involving architecture, optimization, or significant feature work level:intermediate Moderate complexity tasks mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. refactor type:bug Something isn't working as expected type:refactor Code changes that neither fix a bug nor add a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve ESLint warnings and code smells across the codebase

3 participants