fix(validations): coerce duplicate query parameter arrays into single values#6121
Open
MasterJi27 wants to merge 2 commits into
Open
fix(validations): coerce duplicate query parameter arrays into single values#6121MasterJi27 wants to merge 2 commits into
MasterJi27 wants to merge 2 commits into
Conversation
… values Closes JhaSourav07#5267 - Add coerceQueryParams() to extract the first value of duplicate keys - Apply coerceQueryParams() before Zod validation in all GET endpoints - Add unit tests for duplicate parameter coercion
Contributor
|
@MasterJi27 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
📦 Next.js Bundle Size Report (Gzipped Sizes)✨ No significant bundle size changes detected. 📊 Summary of Totals
|
Aamod-Dev
approved these changes
Jun 21, 2026
Aamod-Dev
left a comment
Collaborator
There was a problem hiding this comment.
Handling duplicate query parameters securely is a classic edge case. Coercing query parameters using coerceQueryParams in app/api/compare/route.ts and others before passing them to the Zod schema ensures we don't hit unexpected validation failures when parameters are passed multiple times. Approved!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5267