fix(themes): implement runtime validation for SVG theme presets#6123
Open
MasterJi27 wants to merge 2 commits into
Open
fix(themes): implement runtime validation for SVG theme presets#6123MasterJi27 wants to merge 2 commits into
MasterJi27 wants to merge 2 commits into
Conversation
Closes JhaSourav07#5272 - Define badgeThemeSchema using Zod to validate BadgeTheme type - Add validateThemes() to validate the themes map - Invoke validateThemes() during module runtime initialization - Add unit tests for runtime theme validation
Contributor
|
@MasterJi27 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
📦 Next.js Bundle Size Report (Gzipped Sizes)
📊 Summary of Totals
|
Aamod-Dev
added
GSSoC 2026
mentor:Aamod007
level:intermediate
Aamod-Dev
approved these changes
Jun 21, 2026
Aamod-Dev
left a comment
Aamod-Dev
left a comment
Collaborator
There was a problem hiding this comment.
Adding Zod runtime validation for theme presets in lib/svg/themes.ts is an excellent safeguard against misconfigured hex colors in newly added themes. This guarantees that all themes match the required format before they can break the SVG renderer. Approved!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5272