fix(streak): add .filter(Boolean) guards to aggregate/calculate calendars#6128
Closed
hardik-bhalekar wants to merge 1 commit into
Closed
fix(streak): add .filter(Boolean) guards to aggregate/calculate calendars#6128hardik-bhalekar wants to merge 1 commit into
hardik-bhalekar wants to merge 1 commit into
Conversation
Contributor
|
@hardik-bhalekar is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
👋 Hey @hardik-bhalekar! Thanks for your contribution! 🎉 Unfortunately, this PR has been automatically closed because it is not linked to any open issue. To resolve this, please do the following:
We look forward to reviewing your PR once an issue is linked! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds defensive
.filter(Boolean)guards to every array iteration overcalendar.weeksandcontributionDaysin the data-processing pipeline, preventingTypeError: Cannot read properties of nullcrashes when the GitHub GraphQL API returns sparse ornullcalendar records.Problem
The GitHub Contributions GraphQL API occasionally returns
nullentries inside theweeksarray orcontributionDayssub-arrays — especially for newly created accounts, accounts with gaps in activity, or during API degradation. The existing code uses.flatMap()and.forEach()on these arrays without null guards, causing runtime crashes that surface as 500 errors on the streak card endpoint.Changes
lib/github.ts—fetchContributionsUncached().filter(Boolean)after(calendar.weeks || [])before.map().filter(Boolean)aftercontributionDaysarray before.map()lib/calculate.ts— Multiple functionscalculateStreak().filter(Boolean)onweeksandcontributionDays; added!d.datenull-checkcalculateMonthlyStats().filter(Boolean)onweeksandcontributionDaysaggregateCalendars().filter(Boolean)on all 3weeks/contributionDaysiteration loopscalculateWrappedStats().filter(Boolean)onweeksandcontributionDaysnormalizeCalendarToTimezone().filter(Boolean)oncalendar.weeksandcontributionDaysWhy
.filter(Boolean)This is the idiomatic JavaScript/TypeScript pattern for stripping
null,undefined,0, and""from arrays in a single pass. It's safe here because contribution day objects are always truthy when present, and falsy entries are always invalid API artifacts.Testing
npx tsc --noEmitpasses with zero errors