Skip to content

fix(svgRenderer):update duplicate step comment in svgRenderer #6131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JhaSourav07 merged 1 commit into from
Jun 21, 2026
+7 −7
Merged

fix(svgRenderer):update duplicate step comment in svgRenderer #6131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/utils/svgRenderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export function generateOptimizedSvg(contributionData: ContributionNode[]): stri
);

// ==========================================
// STEP 1: THE GRID MAP MATRIX SYSTEM
// STEP 2: THE GRID MAP DICTIONARY SETUP
// ==========================================
const gridMap: Record<string, number> = {};
for (let i = 0; i < safeData.length; i++) {
Expand All @@ -34,7 +34,7 @@ export function generateOptimizedSvg(contributionData: ContributionNode[]): stri
}

// ==========================================
// STEP 2: DEFINE THE MASTER BLUEPRINTS (<defs>)
// STEP 3: DEFINE THE MASTER BLUEPRINTS (<defs>)
// ==========================================
const svgDefs = `
<defs>
Expand Down Expand Up @@ -67,7 +67,7 @@ export function generateOptimizedSvg(contributionData: ContributionNode[]): stri
let svgElements = '';

// ==========================================
// STEPS 3, 4 & 5: ITERATE, CULL, & INSTANTIATE
// STEPS 4, 5 & 6: ITERATE, CULL, & INSTANTIATE
// ==========================================
for (const node of sortedData) {
const x = typeof node.x === 'number' ? node.x : 0;
Expand All @@ -78,14 +78,14 @@ export function generateOptimizedSvg(contributionData: ContributionNode[]): stri
const isoX = (x - y) * (tileWidth / 2);
const isoY = (x + y) * (tileHeight / 2);

// STEP 3: Zero-Height Pruning
// STEP 4: Zero-Height Pruning
if (count === 0) {
// Omit building blocks; just lay a completely flat ground base footprint vector
svgElements += `<use href="#iso-top" x="${isoX}" y="${isoY}" fill="#1e293b" opacity="0.2"/>\n`;
continue;
}

// STEP 4: Adjacent Occlusion Culling Check
// STEP 5: Adjacent Occlusion Culling Check
// Get the height of the tower directly in front of this one (x+1, y+1)
const frontTowerHeight = gridMap[`${x + 1},${y + 1}`] || 0;

Expand All @@ -94,7 +94,7 @@ export function generateOptimizedSvg(contributionData: ContributionNode[]): stri
continue;
}

// STEP 5: Scale blueprints to custom height offsets
// STEP 6: Scale blueprints to custom height offsets
const calculatedHeight = count * blockHeightUnit;

svgElements += `
Expand All @@ -107,7 +107,7 @@ export function generateOptimizedSvg(contributionData: ContributionNode[]): stri
}

// ==========================================
// STEP 6: OUTPUT FINISHED ROOT SVG STRING
// STEP 7: OUTPUT FINISHED ROOT SVG STRING
// ==========================================
return `
<svg xmlns="http://www.w3.org/2000/svg" viewBox="-200 -50 800 600" width="100%" height="100%" role="img" aria-labelledby="svg-title svg-desc">
Expand Down
Loading