docs(rate-limit): clarify KV-backed persistence vs in-memory fallback#6208
Conversation
Improve documentation for RateLimiter and RefreshRateLimiter to clearly explain the dual-mode behavior: KV-backed persistence when configured, in-memory fallback when not. Add setup instructions reference for Upstash Redis/Vercel KV.
|
@vipul674 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
📦 Next.js Bundle Size Report (Gzipped Sizes)✨ No significant bundle size changes detected. 📊 Summary of Totals
|
|
@JhaSourav07 Please Review. |
|
@JhaSourav07 I have submitted the fix. Please let me know if any changes are needed! |
Aamod-Dev
left a comment
There was a problem hiding this comment.
Great work clearly documenting the behavior of our rate limiters. I appreciate that you've explicitly outlined the dual-mode in lib/rate-limit.ts and noted the serverless lifecycle limitations of RefreshRateLimiter in services/github/refresh-rate-limiter.ts. The link to the Upstash docs is a nice touch for developers looking to configure persistence. This improves the developer experience significantly. Approved!
|
🎉 Congratulations @vipul674! Your PR has been successfully merged. 🚀 Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.
Keep building! 💻✨ |
Related Issue
Closes #6207
Type of Change
Description
Improve documentation for and to clearly explain the dual-mode behavior:
Changes
Testing
Checklist