fix(svg): sanitize border and labelColor attributes to prevent XSS#6227
Merged
Conversation
ab9b02e to
8adb03b
Compare
8adb03b to
2bc6850
Compare
Contributor
📦 Next.js Bundle Size Report (Gzipped Sizes)✨ No significant bundle size changes detected. 📊 Summary of Totals
|
2bc6850 to
660cc12
Compare
Aamod-Dev
approved these changes
Jun 21, 2026
Aamod-Dev
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for finding and patching this! Unsanitized interpolation of query parameters into SVGs is a classic vector for XSS. Applying sanitizeHexColor to border and labelColor in lib/svg/generator.ts effectively closes this vulnerability. Approved!
Contributor
|
🎉 Congratulations @diksha78dev! Your PR has been successfully merged. 🚀 Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.
Keep building! 💻✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6159
This PR addresses an SVG injection (XSS) vulnerability by applying strict hex color sanitization to the
labelColorandborderquery parameters in the SVG generator. These parameters were previously interpolated directly into the SVG template without validation.params.labelColorwithsanitizeHexColorusing the theme's base color as a secure fallback.params.borderoccurrences withsanitizeHexColorusing#000000as a secure fallback.Pillar
Visual Preview
N/A — Security fix. No visual changes under normal usage. Malformed or malicious inputs now gracefully fallback to safe default colors.
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.