Skip to content

fix(validations): use UTC year for streak/wrapped year validation upper bound #6246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JhaSourav07 merged 1 commit into from
Jun 21, 2026
+3 −3
Merged

fix(validations): use UTC year for streak/wrapped year validation upper bound #6246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/validations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ const baseStreakParamsSchema = z.object({
(val) => {
if (!val) return true;
const yearNum = parseInt(val, 10);
const currentYear = new Date().getFullYear();
const currentYear = new Date().getUTCFullYear();
return /^\d{4}$/.test(val) && yearNum >= 2008 && yearNum <= currentYear;
},
{
Expand Down Expand Up @@ -672,7 +672,7 @@ export const wrappedParamsSchema = z.object({
(val) => {
if (!val) return true;
const yearNum = parseInt(val, 10);
const currentYear = new Date().getFullYear();
const currentYear = new Date().getUTCFullYear();
return /^\d{4}$/.test(val) && yearNum >= 2008 && yearNum <= currentYear;
},
{
Expand Down
2 changes: 1 addition & 1 deletion lib/validations.year.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { describe, it, expect } from 'vitest';
import { streakParamsSchema, wrappedParamsSchema } from './validations';

const CURRENT_YEAR = new Date().getFullYear();
const CURRENT_YEAR = new Date().getUTCFullYear();
const EXPECTED_ERROR = 'GitHub was founded in 2008. Please provide a year of 2008 or later.';

function getYearError(result: {
Expand Down
Loading