feat: secure auth refactor with http-only cookies & token rotation#1305
Open
PremSahith wants to merge 1 commit into
Open
feat: secure auth refactor with http-only cookies & token rotation#1305PremSahith wants to merge 1 commit into
PremSahith wants to merge 1 commit into
Conversation
|
@PremSahith is attempting to deploy a commit to the jiya's projects Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for codevibeforyou ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
@JiyaBatra Could you review this and suggest if any improvements are required |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Related Issue
Closes: #1295
📌 Description
This PR addresses issue #1295 by completely overhauling the application's authentication flow. It migrates away from the insecure practice of returning JWT access tokens in the JSON response payload and storing them in client-side
localStorage. Instead, it introduces a dual-token (Access + Refresh) architecture utilizing strict, HttpOnly cookies to prevent Cross-Site Scripting (XSS) token theft and implements automated token rotation.✨ Changes Made
login.js,register.js,googleAuth.js) to generate a short-livedaccessToken(15 mins) and a long-livedrefreshToken(7 days), attached directly to the response via secure, HttpOnly cookies./api/auth/refreshendpoint to handle token rotation securely when the current access token expires.client/src/config/axiosSetup.js) that automatically catches401 Unauthorizedresponses, hits the refresh endpoint, and silently retries the failed requests.AuthProvider.jsx,Signup.jsx,Login.jsx, andOAuthCallback.jsxto completely remove all traces oflocalStorage.setItem('authToken'), leaving only non-sensitiveuserdata in state for quick UI hydration.📷 Screenshots
N/A - This is a purely logical and security-oriented refactor, no user-facing UI changes were made.
🧪 Type of Change
✔️ Checklist
🚨 Notes for Contributors
REFRESH_TOKEN_SECRETand optionallyREFRESH_TOKEN_EXPIRES_INare configured in your.envfor the backend.